APIE-1043: Remove broken RTCE region live test.#3358
Merged
Conversation
|
🎉 All Contributor License Agreements have been signed. Ready to merge. |
There was a problem hiding this comment.
Pull request overview
This PR removes a deterministic failing RTCE region live test from test/live, restoring successful live-test runs for live_test builds that include RTCE tags while leaving mocked/integration RTCE region coverage in place.
Changes:
- Deleted
TestRegionCRUDLive, which asserted that real RTCE region output contained a randomly generated region name. - Removed the associated
live_test && (all || rtce)test file from the live suite.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Cynthia Qin (cqin-confluent)
approved these changes
May 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release Notes
Checklist
Whatsection below whether this PR applies to Confluent Cloud, Confluent Platform, or both.Test & Reviewsection below.Blast Radiussection below.What
Applies to: Confluent Cloud.
test/live/region_live_test.go(added in #3331 alongside the RTCE control plane commands) runsconfluent rtce region listand asserts that the output containsuniqueName("region")— a freshly generated random string.Real Confluent Cloud RTCE regions can never match that random name, so the assertion fails deterministically on every run:
--- FAIL: TestLive/TestRegionCRUDLive (3.48s)
--- FAIL: TestLive/TestRegionCRUDLive/List_RTCE_regions (0.37s)
This blocks every live-test group that pulls in the
rtce/allbuild tag. This PR deletes the broken file so the live-test suite can run cleanly again. The corresponding unit/integration tests and mock handlers for RTCEregions (
test/region_test.go,test/test-server/region_handler.go) are unchanged. A proper live test can be reintroduced in a follow-up once a stable fixture or substring assertion is defined.Blast Radius
No customer impact — this PR only touches a
live_test-tagged file undertest/live/and does not change any shipped CLI code. The only effect is that the RTCE-region live test no longer runs; coverage for the RTCE regioncommand remains via the existing unit and integration tests.
References
Test & Review
Before (from the live-test run):
--- FAIL: TestLive (0.00s)
--- FAIL: TestLive/TestRegionCRUDLive (3.48s)
--- FAIL: TestLive/TestRegionCRUDLive/List_RTCE_regions (0.37s)
After deletion, the live-test package still builds cleanly under both relevant tag combinations:
$ go vet -tags="live_test,all" ./test/live/
$ go vet -tags="live_test,rtce" ./test/live/
Both invocations succeed with no output, and
TestRegionCRUDLiveno longer runs (no other test references it).