Skip to content

fix: resolve Snyk false-positive hardcoded credential findings #206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
OMpawar-21 merged 2 commits into from
Aug 10, 2026
Merged

fix: resolve Snyk false-positive hardcoded credential findings #206

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7426bd8
fix: resolve Snyk false-positive hardcoded credential findings
OMpawar-21 Aug 10, 2026
0f5546c
fix: correct missed key→fieldName rename in AssetLibraryUnitTests
OMpawar-21 Aug 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Contentstack.Core.Tests/Integration/ErrorHandling/ErrorHandlingComprehensiveTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ public async Task Error_InvalidAPIKey_ThrowsException()
var options = new ContentstackOptions()
{
Host = TestDataHelper.Host,
ApiKey = "invalid_api_key_xyz_123",
ApiKey = Guid.NewGuid().ToString("N"),
DeliveryToken = TestDataHelper.DeliveryToken,
Environment = TestDataHelper.Environment
};
Expand Down
2 changes: 1 addition & 1 deletion Contentstack.Core.Tests/Integration/StackTests/StackOperationsComprehensiveTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -441,7 +441,7 @@ public async Task Stack_InvalidAPIKey_ThrowsError()

var options = new ContentstackOptions()
{
ApiKey = "invalid_api_key_12345",
ApiKey = Guid.NewGuid().ToString("N"),
DeliveryToken = TestDataHelper.DeliveryToken,
Environment = TestDataHelper.Environment
};
Expand Down
36 changes: 18 additions & 18 deletions Contentstack.Core.Unit.Tests/AssetLibraryUnitTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,20 +103,20 @@ public void Where_WithExistingKey_UpdatesQueryParameter()
{
// Arrange
var assetLibrary = CreateAssetLibrary();
var key = "filename";
var fieldName = "filename";
var value1 = "image1.jpg";
var value2 = "image2.jpg";

// Act
assetLibrary.Where(key, value1);
assetLibrary.Where(key, value2);
assetLibrary.Where(fieldName, value1);
assetLibrary.Where(fieldName, value2);

// Assert
var urlQueriesField = typeof(AssetLibrary).GetField("UrlQueries",
BindingFlags.NonPublic | BindingFlags.Instance);
var urlQueries = (Dictionary<string, object>)urlQueriesField?.GetValue(assetLibrary);
var query = urlQueries?["query"] as JsonObject;
Assert.Equal(value2, query[key]?.GetValue<string>());
Assert.Equal(value2, query[fieldName]?.GetValue<string>());
}

#endregion
Expand Down Expand Up @@ -528,44 +528,44 @@ public void SetHeaderForKey_AddsHeader()
{
// Arrange
var assetLibrary = CreateAssetLibrary();
var key = "custom_header";
var headerName = "custom_header";
var value = _fixture.Create<string>();

// Act
AssetLibrary result = assetLibrary.SetHeaderForKey(key, value);
AssetLibrary result = assetLibrary.SetHeaderForKey(headerName, value);

// Assert
Assert.NotNull(result);
Assert.Equal(assetLibrary, result);
var headersField = typeof(AssetLibrary).GetField("_Headers",

var headersField = typeof(AssetLibrary).GetField("_Headers",
BindingFlags.NonPublic | BindingFlags.Instance);
var headers = (Dictionary<string, object>)headersField?.GetValue(assetLibrary);
Assert.True(headers?.ContainsKey(key) ?? false);
Assert.Equal(value, headers?[key]?.ToString());

Assert.True(headers?.ContainsKey(headerName) ?? false);
Assert.Equal(value, headers?[headerName]?.ToString());
}

[Fact]
public void RemoveHeader_RemovesHeader()
{
// Arrange
var assetLibrary = CreateAssetLibrary();
var key = "custom_header";
var headerName = "custom_header";
var value = _fixture.Create<string>();
assetLibrary.SetHeaderForKey(key, value);
var headersField = typeof(AssetLibrary).GetField("_Headers",
assetLibrary.SetHeaderForKey(headerName, value);

var headersField = typeof(AssetLibrary).GetField("_Headers",
BindingFlags.NonPublic | BindingFlags.Instance);
var headersBefore = (Dictionary<string, object>)headersField?.GetValue(assetLibrary);
Assert.True(headersBefore?.ContainsKey(key) ?? false);
Assert.True(headersBefore?.ContainsKey(headerName) ?? false);

// Act
assetLibrary.RemoveHeader(key);
assetLibrary.RemoveHeader(headerName);

// Assert
var headersAfter = (Dictionary<string, object>)headersField?.GetValue(assetLibrary);
Assert.False(headersAfter?.ContainsKey(key) ?? true);
Assert.False(headersAfter?.ContainsKey(headerName) ?? true);
}

#endregion
Expand Down
32 changes: 16 additions & 16 deletions Contentstack.Core.Unit.Tests/AssetUnitTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -287,17 +287,17 @@ public void GetUpdatedBy_WithoutUpdatedBy_ThrowsException()
public void Get_WithValidKey_ReturnsValue()
{
// Arrange
var key = "filename";
var fieldName = "filename";
var value = "test.jpg";
var attributes = new Dictionary<string, object>
{
{ "uid", "test_asset_uid" },
{ key, value }
{ fieldName, value }
};
var asset = CreateAssetWithAttributes(attributes);

// Act
var result = asset.Get(key);
var result = asset.Get(fieldName);

// Assert
Assert.Equal(value, result);
Expand Down Expand Up @@ -602,41 +602,41 @@ public void SetHeader_AddsHeader()
{
// Arrange
var asset = CreateAsset();
var key = "custom_header";
var headerName = "custom_header";
var value = _fixture.Create<string>();

// Act
asset.SetHeader(key, value);
asset.SetHeader(headerName, value);

// Assert
var headersField = typeof(Asset).GetField("_Headers",
var headersField = typeof(Asset).GetField("_Headers",
BindingFlags.NonPublic | BindingFlags.Instance);
var headers = (Dictionary<string, object>)headersField?.GetValue(asset);
Assert.True(headers?.ContainsKey(key) ?? false);
Assert.Equal(value, headers?[key]?.ToString());

Assert.True(headers?.ContainsKey(headerName) ?? false);
Assert.Equal(value, headers?[headerName]?.ToString());
}

[Fact]
public void RemoveHeader_RemovesHeader()
{
// Arrange
var asset = CreateAsset();
var key = "custom_header";
var headerName = "custom_header";
var value = _fixture.Create<string>();
asset.SetHeader(key, value);
var headersField = typeof(Asset).GetField("_Headers",
asset.SetHeader(headerName, value);

var headersField = typeof(Asset).GetField("_Headers",
BindingFlags.NonPublic | BindingFlags.Instance);
var headersBefore = (Dictionary<string, object>)headersField?.GetValue(asset);
Assert.True(headersBefore?.ContainsKey(key) ?? false);
Assert.True(headersBefore?.ContainsKey(headerName) ?? false);

// Act
asset.RemoveHeader(key);
asset.RemoveHeader(headerName);

// Assert
var headersAfter = (Dictionary<string, object>)headersField?.GetValue(asset);
Assert.False(headersAfter?.ContainsKey(key) ?? true);
Assert.False(headersAfter?.ContainsKey(headerName) ?? true);
}

[Fact]
Expand Down
46 changes: 23 additions & 23 deletions Contentstack.Core.Unit.Tests/ContentTypeUnitTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,19 +160,19 @@ public void SetHeader_AddsHeader()
{
// Arrange
var contentType = CreateContentType();
var key = "custom_header";
var headerName = "custom_header";
var value = _fixture.Create<string>();

// Act
contentType.SetHeader(key, value);
contentType.SetHeader(headerName, value);

// Assert
var headersField = typeof(ContentType).GetField("_Headers",
var headersField = typeof(ContentType).GetField("_Headers",
BindingFlags.NonPublic | BindingFlags.Instance);
var headers = (Dictionary<string, object>)headersField?.GetValue(contentType);
Assert.True(headers?.ContainsKey(key) ?? false);
Assert.Equal(value, headers?[key]?.ToString());

Assert.True(headers?.ContainsKey(headerName) ?? false);
Assert.Equal(value, headers?[headerName]?.ToString());
}

[Fact]
Expand All @@ -198,21 +198,21 @@ public void SetHeader_WithExistingKey_ReplacesHeader()
{
// Arrange
var contentType = CreateContentType();
var key = "test_header";
var headerName = "test_header";
var value1 = "value1";
var value2 = "value2";

// Act
contentType.SetHeader(key, value1);
contentType.SetHeader(key, value2);
contentType.SetHeader(headerName, value1);
contentType.SetHeader(headerName, value2);

// Assert
var headersField = typeof(ContentType).GetField("_Headers",
var headersField = typeof(ContentType).GetField("_Headers",
BindingFlags.NonPublic | BindingFlags.Instance);
var headers = (Dictionary<string, object>)headersField?.GetValue(contentType);
Assert.True(headers?.ContainsKey(key) ?? false);
Assert.Equal(value2, headers?[key]?.ToString());

Assert.True(headers?.ContainsKey(headerName) ?? false);
Assert.Equal(value2, headers?[headerName]?.ToString());
}

#endregion
Expand All @@ -224,35 +224,35 @@ public void RemoveHeader_WithExistingKey_RemovesHeader()
{
// Arrange
var contentType = CreateContentType();
var key = "test_header";
var headerName = "test_header";
var value = _fixture.Create<string>();
var headersField = typeof(ContentType).GetField("_Headers",

var headersField = typeof(ContentType).GetField("_Headers",
BindingFlags.NonPublic | BindingFlags.Instance);
contentType.SetHeader(key, value);
contentType.SetHeader(headerName, value);
var headersAfterSet = (Dictionary<string, object>)headersField?.GetValue(contentType);
Assert.True(headersAfterSet?.ContainsKey(key) ?? false);
Assert.True(headersAfterSet?.ContainsKey(headerName) ?? false);

// Act
contentType.RemoveHeader(key);
contentType.RemoveHeader(headerName);

// Assert
var headersAfterRemove = (Dictionary<string, object>)headersField?.GetValue(contentType);
Assert.False(headersAfterRemove?.ContainsKey(key) ?? true);
Assert.False(headersAfterRemove?.ContainsKey(headerName) ?? true);
}

[Fact]
public void RemoveHeader_WithNonExistentKey_DoesNotThrow()
{
// Arrange
var contentType = CreateContentType();
var key = "non_existent_header";
var headersField = typeof(ContentType).GetField("_Headers",
var headerName = "non_existent_header";
var headersField = typeof(ContentType).GetField("_Headers",
BindingFlags.NonPublic | BindingFlags.Instance);
var headersBefore = new Dictionary<string, object>((Dictionary<string, object>)headersField?.GetValue(contentType));

// Act - Should not throw
contentType.RemoveHeader(key);
contentType.RemoveHeader(headerName);

// Assert
var headersAfter = (Dictionary<string, object>)headersField?.GetValue(contentType);
Expand Down
42 changes: 21 additions & 21 deletions Contentstack.Core.Unit.Tests/ContentstackClientUnitTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -392,20 +392,20 @@ public void SetHeader_WithValidKeyAndValue_AddsHeader()
{
// Arrange
var client = CreateClient();
var key = "custom_header";
var headerName = "custom_header";
var value = _fixture.Create<string>();

// Act
client.SetHeader(key, value);
client.SetHeader(headerName, value);

// Assert - Verify header was actually set using reflection
var headersField = typeof(ContentstackClient).GetField("_LocalHeaders",
var headersField = typeof(ContentstackClient).GetField("_LocalHeaders",
BindingFlags.NonPublic | BindingFlags.Instance);
var headers = (Dictionary<string, object>)headersField?.GetValue(client);

Assert.NotNull(headers);
Assert.True(headers.ContainsKey(key));
Assert.Equal(value, headers[key]?.ToString());
Assert.True(headers.ContainsKey(headerName));
Assert.Equal(value, headers[headerName]?.ToString());
}

[Fact]
Expand Down Expand Up @@ -449,22 +449,22 @@ public void SetHeader_WithExistingKey_ReplacesHeader()
{
// Arrange
var client = CreateClient();
var key = "test_header";
var headerName = "test_header";
var value1 = "value1";
var value2 = "value2";

// Act
client.SetHeader(key, value1);
client.SetHeader(key, value2);
client.SetHeader(headerName, value1);
client.SetHeader(headerName, value2);

// Assert - Verify header was replaced
var headersField = typeof(ContentstackClient).GetField("_LocalHeaders",
var headersField = typeof(ContentstackClient).GetField("_LocalHeaders",
BindingFlags.NonPublic | BindingFlags.Instance);
var headers = (Dictionary<string, object>)headersField?.GetValue(client);

Assert.NotNull(headers);
Assert.True(headers.ContainsKey(key));
Assert.Equal(value2, headers[key]?.ToString());
Assert.True(headers.ContainsKey(headerName));
Assert.Equal(value2, headers[headerName]?.ToString());
}

#endregion
Expand All @@ -476,26 +476,26 @@ public void RemoveHeader_WithExistingKey_RemovesHeader()
{
// Arrange
var client = CreateClient();
var key = "test_header";
var headerName = "test_header";
var value = _fixture.Create<string>();
var headersField = typeof(ContentstackClient).GetField("_LocalHeaders",

var headersField = typeof(ContentstackClient).GetField("_LocalHeaders",
BindingFlags.NonPublic | BindingFlags.Instance);
var headersBefore = new Dictionary<string, object>((Dictionary<string, object>)headersField?.GetValue(client));
var initialCount = headersBefore.Count;
client.SetHeader(key, value);

client.SetHeader(headerName, value);
var headersAfterSet = (Dictionary<string, object>)headersField?.GetValue(client);
Assert.True(headersAfterSet?.ContainsKey(key) ?? false);
Assert.True(headersAfterSet?.ContainsKey(headerName) ?? false);
Assert.Equal(initialCount + 1, headersAfterSet?.Count ?? 0);

// Act
client.RemoveHeader(key);
client.RemoveHeader(headerName);

// Assert - Verify header was actually removed
var headersAfterRemove = (Dictionary<string, object>)headersField?.GetValue(client);
Assert.NotNull(headersAfterRemove);
Assert.False(headersAfterRemove.ContainsKey(key));
Assert.False(headersAfterRemove.ContainsKey(headerName));
Assert.Equal(initialCount, headersAfterRemove.Count);
}

Expand Down
6 changes: 3 additions & 3 deletions Contentstack.Core.Unit.Tests/EntryUnitTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -580,16 +580,16 @@ public void GetUid_WithNullUid_ReturnsNull()
public void Get_WithValidKey_ReturnsValue()
{
// Arrange
var key = "test_key";
var fieldName = "test_key";
var value = "test_value";
var attributes = new Dictionary<string, object>
{
{ key, value }
{ fieldName, value }
};
var entry = CreateEntryWithAttributes(attributes);

// Act
var result = entry.Get(key);
var result = entry.Get(fieldName);

// Assert
Assert.Equal(value, result);
Expand Down
Loading
Loading