Skip to content

Upgrade Node.js to v22, add Astro & Analog presets, fix Apollo withDisabledDeprecations error.#124

Closed
SakshiKoli-CS wants to merge 20 commits intomainfrom
staging
Closed

Upgrade Node.js to v22, add Astro & Analog presets, fix Apollo withDisabledDeprecations error.#124
SakshiKoli-CS wants to merge 20 commits intomainfrom
staging

Conversation

@SakshiKoli-CS
Copy link
Copy Markdown
Contributor

test: add logs polling Apollo deprecation regression tests
fix: avoid TypeError when Apollo withDisabledDeprecations is not a function
chore: upgrade Node.js to 22 and update @types/node
fix: remove duplicate supportedFrameworksForServerCommands property
feat: Add ANALOG framework preset option
feat: Add ASTRO farmework preset option
chore: update packages for security issues

Harshi-Shah-CS and others added 20 commits February 18, 2026 12:40
chore: update packages for security issues
feat: Add ASTRO farmework preset option
feat: Add ANALOG framework preset option
fix: remove duplicate supportedFrameworksForServerCommands property
chore: upgrade Node.js to 22 and update @types/node
Revert "chore: upgrade Node.js to 22 and update @types/node"
chore: upgrade Node.js to 22 and update @types/node
fix: avoid TypeError when Apollo withDisabledDeprecations is not a function
test: add logs polling Apollo deprecation regression tests
chore: launch-cli patch version upgrade
Upgrade Node.js to v22, add Astro & Analog presets, fix Apollo withDisabledDeprecations error.
@SakshiKoli-CS SakshiKoli-CS requested review from a team as code owners March 25, 2026 11:49
@github-actions
Copy link
Copy Markdown

🔒 Security Scan Results

ℹ️ Note: Only vulnerabilities with available fixes (upgrades or patches) are counted toward thresholds.

Check Type Count (with fixes) Without fixes Threshold Result
🔴 Critical Severity 0 0 10 ✅ Passed
🟠 High Severity 0 0 25 ✅ Passed
🟡 Medium Severity 0 0 500 ✅ Passed
🔵 Low Severity 0 0 1000 ✅ Passed

⏱️ SLA Breach Summary

✅ No SLA breaches detected. All vulnerabilities are within acceptable time thresholds.

Severity Breaches (with fixes) Breaches (no fixes) SLA Threshold (with/no fixes) Status
🔴 Critical 0 0 15 / 30 days ✅ Passed
🟠 High 0 0 30 / 120 days ✅ Passed
🟡 Medium 0 0 90 / 365 days ✅ Passed
🔵 Low 0 0 180 / 365 days ✅ Passed

✅ BUILD PASSED - All security checks passed

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the CLI to target Node.js 22, adds Analog and Astro framework presets to the configuration, and hardens Apollo deprecation-handling logic to avoid runtime failures when Apollo’s withDisabledDeprecations helper is missing or not callable (with regression tests added).

Changes:

  • Make Apollo deprecation suppression optional and resilient when the helper cannot be required or isn’t a function.
  • Add Jest regression tests covering Apollo deprecation helper edge cases.
  • Extend framework presets/configuration for Analog and Astro, and bump Node engine + related dependencies.

Reviewed changes

Copilot reviewed 4 out of 5 changed files in this pull request and generated 3 comments.

File Description
src/util/logs-polling-utilities.ts Adds createRequire-based loading and guards around Apollo deprecation helper usage; minor formatting adjustments.
src/util/logs-polling-utilities.test.ts Adds Jest regression tests for Apollo deprecation helper loading/behavior.
src/config/index.ts Adds ANALOG/ASTRO presets (output dirs + selection options) and updates supported frameworks for server commands.
package.json Bumps version, Node engine requirement to >=22, and updates dependency overrides/dev tooling versions.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +73 to +75
} catch {
void 0;
}
Copy link

Copilot AI Mar 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The catch { void 0; } pattern will likely fail linting under no-unused-expressions (enabled via eslint.configs.recommended). Use a non-empty catch body that doesn’t introduce an unused expression (e.g., add a short comment like // ignore or disable the specific rule locally) instead of void 0;.

Copilot uses AI. Check for mistakes.
Comment on lines +82 to +84
} catch {
void 0;
}
Copy link

Copilot AI Mar 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This catch { void 0; } is likely to be flagged by no-unused-expressions. Prefer a comment-only catch block (or an explicit ignore comment) so it’s both non-empty and lint-clean.

Copilot uses AI. Check for mistakes.
Comment on lines +94 to +96
} catch {
void 0;
}
Copy link

Copilot AI Mar 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same issue here: void 0; in a catch block is an unused expression and may break linting. Replace with a comment-only catch body or another lint-safe no-op.

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants