Upgrade Node.js to v22, add Astro & Analog presets, fix Apollo withDisabledDeprecations error.#124
Upgrade Node.js to v22, add Astro & Analog presets, fix Apollo withDisabledDeprecations error.#124SakshiKoli-CS wants to merge 20 commits intomainfrom
Conversation
chore: update packages for security issues
feat: Add ASTRO farmework preset option
feat: Add ANALOG framework preset option
fix: remove duplicate supportedFrameworksForServerCommands property
chore: upgrade Node.js to 22 and update @types/node
Revert "chore: upgrade Node.js to 22 and update @types/node"
chore: upgrade Node.js to 22 and update @types/node
fix: avoid TypeError when Apollo withDisabledDeprecations is not a function
test: add logs polling Apollo deprecation regression tests chore: launch-cli patch version upgrade
Upgrade Node.js to v22, add Astro & Analog presets, fix Apollo withDisabledDeprecations error.
🔒 Security Scan Results
⏱️ SLA Breach Summary
✅ BUILD PASSED - All security checks passed |
There was a problem hiding this comment.
Pull request overview
This PR updates the CLI to target Node.js 22, adds Analog and Astro framework presets to the configuration, and hardens Apollo deprecation-handling logic to avoid runtime failures when Apollo’s withDisabledDeprecations helper is missing or not callable (with regression tests added).
Changes:
- Make Apollo deprecation suppression optional and resilient when the helper cannot be required or isn’t a function.
- Add Jest regression tests covering Apollo deprecation helper edge cases.
- Extend framework presets/configuration for Analog and Astro, and bump Node engine + related dependencies.
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/util/logs-polling-utilities.ts | Adds createRequire-based loading and guards around Apollo deprecation helper usage; minor formatting adjustments. |
| src/util/logs-polling-utilities.test.ts | Adds Jest regression tests for Apollo deprecation helper loading/behavior. |
| src/config/index.ts | Adds ANALOG/ASTRO presets (output dirs + selection options) and updates supported frameworks for server commands. |
| package.json | Bumps version, Node engine requirement to >=22, and updates dependency overrides/dev tooling versions. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| } catch { | ||
| void 0; | ||
| } |
There was a problem hiding this comment.
The catch { void 0; } pattern will likely fail linting under no-unused-expressions (enabled via eslint.configs.recommended). Use a non-empty catch body that doesn’t introduce an unused expression (e.g., add a short comment like // ignore or disable the specific rule locally) instead of void 0;.
| } catch { | ||
| void 0; | ||
| } |
There was a problem hiding this comment.
This catch { void 0; } is likely to be flagged by no-unused-expressions. Prefer a comment-only catch block (or an explicit ignore comment) so it’s both non-empty and lint-clean.
| } catch { | ||
| void 0; | ||
| } |
There was a problem hiding this comment.
Same issue here: void 0; in a catch block is an unused expression and may break linting. Replace with a comment-only catch body or another lint-safe no-op.
test: add logs polling Apollo deprecation regression tests
fix: avoid TypeError when Apollo withDisabledDeprecations is not a function
chore: upgrade Node.js to 22 and update @types/node
fix: remove duplicate supportedFrameworksForServerCommands property
feat: Add ANALOG framework preset option
feat: Add ASTRO farmework preset option
chore: update packages for security issues