fix: sync discovery schema/spec with IETF-RFC.md#317
fix: sync discovery schema/spec with IETF-RFC.md#317MahdiBaghbani wants to merge 6 commits intodevelopfrom
Conversation
- Fix Appendix D Provider diagram tokens/fields to match the draft (tokenEndPoint, http-sig, http-request-signatures, publicKeys[]) - Align spec.yaml wording/examples with the draft (capability tokens, accessTypes, tokenEndPoint URL vs inviteAcceptDialog path) - Move discovery schema to schemas/ocm-discovery.jsonc with draft-strict URL rules Signed-off-by: Mahdi Baghbani <mahdi-baghbani@azadehafzar.io>
Signed-off-by: Mahdi Baghbani <mahdi-baghbani@azadehafzar.io>
Signed-off-by: Mahdi Baghbani <mahdi-baghbani@azadehafzar.io>
glpatcern
left a comment
There was a problem hiding this comment.
Thanks Mahdi (and happy new year!). I have a comment on the comments ;)
Signed-off-by: Mahdi Baghbani <mahdi-baghbani@azadehafzar.io>
Signed-off-by: Mahdi Baghbani <mahdi-baghbani@azadehafzar.io>
|
The OpenAPI spec says In practice, discovery returns something like I didn't do anything about this as part of this PR, just want to know your opinion on it |
Thanks for raising this, it seems implementations are not using the OpenAPI toolchain (Reva is not for sure). The issue was introduced once we added a |
|
@glpatcern Yes, that's the correct thing to do but we also should note that the "ocm" isn't hardcoded, someone would return |
Hmm right, and in the implementations we actually do POST to |
Sorry I was late to read the previous PR and missed some details, here are my fixes:
Draft consistency fixes (
IETF-RFC.md)tokenEndPoint,http-sig,http-request-signatures).OpenAPI alignment (
spec.yaml)accessTypesplural, andtokenEndPointwording + examples).inviteAcceptDialogis a path,tokenEndPointis an absolute URL.Discovery JSON Schema becomes JSONC and follows the draft strictly (
schemas/ocm-discovery.jsonc)inviteAcceptDialogmust start with/,tokenEndPointmust behttp(s)://....publicKey(deprecated) and RFC 9421publicKeys[].