Add native Dang checks for SDK helpers - #2
Open
shykes wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a workspace-installed
sdk-helpers-devmodule with 103 separate Dang@checkfunctions. Run the suite withdagger checkfrom this repository.The checks cover the 93 saved comparison cases and 10 regression cases. They compare exact TOML and JSON bytes, file names, and mode
0644. They also verify all runtimes, loading and updates, validation, version handling, the public API, independent builder branches, and dependency ordering. Expected results and input files are committed with the checks.Improve load errors to identify invalid fields and their expected types. Use stable merge sort with cached dependency keys. Align source argument spelling with the existing
loadTomlandloadJsonpublic names. Add usage and test instructions.Validation:
dagger checkpasses all 103 checks with Daggerv1.0.0-beta.11.dagger functionsconfirms that the root exposes onlymoduleManifest, and the builder exposes the required 19 functions. The review found no production blocker in these changes.