Open
Conversation
GuiProgressbar can fail to show pixels near the min and max values, such as for 98-100% power or coolant on the Power Management screen or the final jump drive charge points in the jump drive controls. This appears to be caused by the GuiProgressbar being filled by a PNG with a transparent border of pixels, which become the only pixels rendered at these extremes, particularly on high-resolution displays. - Remove transparent pixels from edges of the default progress bar fill PNG that caused inaccuracies for values near min and max. Screens that implement GuiProgressbar should manage its width or height using size or margin attributes if necessary. - Conditionally reduce the default width of the fill rect when using a background. This is set to an arbitrary value that approximates the proportions used in existing behavior, but results in a tighter and more accurate fit on high-resolution displays. - Simplify min/max logic using clamps.
Add a GuiElement::setParent function to reparent elements by removing them from their former parent element's tree, adding them to the new parent element's tree, and updating its pointer.
- Rewrite Power Management screen to dynamically add, remove, and populate rows as the screen size and number of systems change. - Use reparenting to dynamically assign system panels to an arbitrary number of layout rows. - Prevent responsive changes from overlapping crew screen selector and main screen controls, even if both are present. - Expand power/coolant key-value displays. - Use layout attributes to build power management panels. - Add the same snap lines to power and coolant sliders as already used on the Engineering screens. - Add heat delta arrows. - Hide coolant sliders when autocoolant is enabled, leaving only the indicator bar. - Update system power, coolant, heat labels with values.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
populate rows as the screen size and number of systems change.
arbitrary number of layout rows.
main screen controls, even if both are present.
on the Engineering screens.
indicator bar.
Depends on #2573 (progress bars) and #2599 (reparenting).
Eight systems, 4:3:
Nine systems, 4:3:
Wide:
Tall:
Heat and energy delta arrows: