Open
Conversation
- Add a title bar to active player chats. - Add minimize button and move close button to title bar. - Consolidate script and chat comms implementations to share panel and title bar layout. - Indicate unread notification state on minimized chat by switching to toggled-on state.
oznogon
force-pushed
the
refactor-comms-overlay
branch
from
45a42e0 to
e942597
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor chat and script dialogs on CommsOverlay to identify the comms target in the panel, and to allow minimizing the panel without closing the conversation.
Screencast_20260408_000336.webm
Since this is implemented on CommsOverlay, this changes behaviors across Relay, Operations, SinglePilot, and Comms-only screens.
Screencast_20260408_001010_small.webm
Fixes part of #2845 (mousewheel scrolling on script comms now works when hovering on the text as well as the scrolbar)