Fix test assertion mismatch in test_move_not_dandiset#1800
Merged
CodyCBakerPhD merged 2 commits intoenh-lad-errors-pathsfrom Feb 14, 2026
Merged
Fix test assertion mismatch in test_move_not_dandiset#1800CodyCBakerPhD merged 2 commits intoenh-lad-errors-pathsfrom
CodyCBakerPhD merged 2 commits intoenh-lad-errors-pathsfrom
Conversation
Reverted test_move_not_dandiset assertion to match the actual error message format from the code. The previous commit e19a1cc incorrectly changed the test to expect a different format than what the code produces. Co-authored-by: CodyCBakerPhD <51133164+CodyCBakerPhD@users.noreply.github.com>
Contributor
Author
|
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Copilot
AI
changed the title
[WIP] Enhance path validation error messages
Fix test assertion mismatch in test_move_not_dandiset
Feb 14, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## enh-lad-errors-paths #1800 +/- ##
=======================================================
Coverage ? 50.45%
=======================================================
Files ? 84
Lines ? 11922
Branches ? 0
=======================================================
Hits ? 6015
Misses ? 5907
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A previous commit incorrectly modified test assertions to expect an error message format that doesn't match the actual code output, causing test failures.
Changes
test_move_not_dandisetassertion to match actual error message format produced bymove.pyError Message Format
Expected (incorrect):
Actual (now tested):
The test now correctly validates the error format: path without quotes, colon separator, and period after "Dandiset".
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.