Skip to content

Fix test assertion mismatch in test_move_not_dandiset#1800

Merged
CodyCBakerPhD merged 2 commits intoenh-lad-errors-pathsfrom
copilot/sub-pr-1792
Feb 14, 2026
Merged

Fix test assertion mismatch in test_move_not_dandiset#1800
CodyCBakerPhD merged 2 commits intoenh-lad-errors-pathsfrom
copilot/sub-pr-1792

Conversation

Copy link
Contributor

Copilot AI commented Feb 14, 2026

A previous commit incorrectly modified test assertions to expect an error message format that doesn't match the actual code output, causing test failures.

Changes

  • Reverted test_move_not_dandiset assertion to match actual error message format produced by move.py

Error Message Format

Expected (incorrect):

'{path}' not a Dandiset because the directory does not contain a 'dandiset.yaml' file.

Actual (now tested):

{path}: not a Dandiset. The directory does not contain a 'dandiset.yaml' file.

The test now correctly validates the error format: path without quotes, colon separator, and period after "Dandiset".


💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Reverted test_move_not_dandiset assertion to match the actual error message format from the code. The previous commit e19a1cc incorrectly changed the test to expect a different format than what the code produces.

Co-authored-by: CodyCBakerPhD <51133164+CodyCBakerPhD@users.noreply.github.com>
Copy link
Contributor Author

Copilot AI commented Feb 14, 2026

Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • 127.0.0.11
    • Triggering command: REDACTED, pid is -1 (packet block)
  • dl.min.io
    • Triggering command: /usr/bin/minio minio server /data /run/containerd/io.containerd.runtime.v2.task/moby/4399dc82caf9301b7c2649fa90416--to-source --pid-file /run/containerd/io.containerd.runtime.v2.task/moby/4399dc82caf9301b7c2649fa90416d96d59fa28559b16582ffdbbbac4d0cedb1/init.pid 4399dc82caf9301b7c2649fa90416d96d59fa28559b16582ffdbbbac4d0cedb1 de/node/bin/bash (dns block)
    • Triggering command: /usr/bin/minio minio server /data uname 086c�� (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Copilot AI changed the title [WIP] Enhance path validation error messages Fix test assertion mismatch in test_move_not_dandiset Feb 14, 2026
Copilot AI requested a review from CodyCBakerPhD February 14, 2026 04:08
@CodyCBakerPhD CodyCBakerPhD marked this pull request as ready for review February 14, 2026 04:22
@codecov
Copy link

codecov bot commented Feb 14, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (enh-lad-errors-paths@e19a1cc). Learn more about missing BASE report.

Additional details and impacted files
@@                   Coverage Diff                   @@
##             enh-lad-errors-paths    #1800   +/-   ##
=======================================================
  Coverage                        ?   50.45%           
=======================================================
  Files                           ?       84           
  Lines                           ?    11922           
  Branches                        ?        0           
=======================================================
  Hits                            ?     6015           
  Misses                          ?     5907           
  Partials                        ?        0           
Flag Coverage Δ
unittests 50.45% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@CodyCBakerPhD CodyCBakerPhD merged commit a767980 into enh-lad-errors-paths Feb 14, 2026
25 of 35 checks passed
@CodyCBakerPhD CodyCBakerPhD deleted the copilot/sub-pr-1792 branch February 14, 2026 04:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments