connect, cli: select cloud routing after authentication - #8
Merged
Merged
Conversation
Connecting to a develop or staging Ark without --env reopened its USB connection after attestation. On Windows, the second open could fail with access denied while the first handle was still being released. Select the cloud route from the authenticated identity before starting cloud services, keeping the original session and existing environment precedence. Cover routing after authentication and rejection before routing. Fixes dark-bio#6 Co-authored-by: Codex <noreply@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Connecting to a develop or staging hardware Ark without
--envfirst opened it with release routing, then closed and immediately reopened USB after attestation. Windows could reject that second open with error 5 while the original handle was still being released.Select cloud routing from the authenticated identity before starting cloud services, keeping the original connection. Environment precedence remains
--env, attestation, launcher metadata, then release. Regression tests cover routing after authentication, rejection before routing, and attested hardware without launcher metadata.Fixes #6.