fix(dpp): block pre-programmed distribution changes on token update#3461
Draft
PastaPastaPasta wants to merge 1 commit intov3.1-devfrom
Draft
fix(dpp): block pre-programmed distribution changes on token update#3461PastaPastaPasta wants to merge 1 commit intov3.1-devfrom
PastaPastaPasta wants to merge 1 commit intov3.1-devfrom
Conversation
Contributor
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
pre_programmed_distributionwas added toTokenDistributionRulesV0but was not checked during token configuration updates,allowing updates to modify emission schedules without any change-control enforcement.Note: this was identified as a security issue by codex. In my investigation, I found that this is NOT a security issue. None of the exposed update methods are able to update
pre_programmed_distributionhowever; in my view, it is best to explicitly check in validation that these do not change.Description
validate_token_config_update_v0that rejects any update which changespre_programmed_distributionby returning aDataContractTokenConfigurationUpdateErrorforpreProgrammedDistribution.Testing
cargo test -p rs-dpp --lib --no-run, which failed because the package is nameddpp(package name mismatch), not due to the code change.cargo test -p dpp --lib --no-run, which compiled the package and built the test binary successfully (test profile finished).Codex Task