Skip to content

ENH: add a no x64 device #224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ev-br wants to merge 1 commit into
base: main
Choose a base branch
from
Open

ENH: add a no x64 device #224

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 17 additions & 3 deletions array_api_strict/_devices.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,13 +2,13 @@
from enum import IntEnum

from ._dtypes import (
DType, float32, float64, complex64, complex128, int64,
DType, float32, float64, complex64, complex128, int64, uint64, int32,
_all_dtypes, _boolean_dtypes, _signed_integer_dtypes,
_unsigned_integer_dtypes, _integer_dtypes, _real_floating_dtypes,
_complex_floating_dtypes, _numeric_dtypes
)

_ALL_DEVICE_NAMES = ("CPU_DEVICE", "device1", "device2", "no_float64")
_ALL_DEVICE_NAMES = ("CPU_DEVICE", "device1", "device2", "no_float64", "no_x64")

class Device:
_device: Final[str]
Expand All @@ -33,8 +33,11 @@ def __hash__(self) -> int:

CPU_DEVICE = Device()
NO_FLOAT64_DEVICE = Device("no_float64")
NO_X64_DEVICE = Device("no_x64")

ALL_DEVICES = (CPU_DEVICE, Device("device1"), Device("device2"), NO_FLOAT64_DEVICE)
ALL_DEVICES = (
CPU_DEVICE, Device("device1"), Device("device2"), NO_FLOAT64_DEVICE, NO_X64_DEVICE
)

class DLDeviceType(IntEnum):
kDLCPU = 1
Expand Down Expand Up @@ -85,6 +88,14 @@ def get_default_dtypes(device: Device | None = None) -> dict[str, DType]:
"integral": int64,
"indexing": int64,
}
elif device == NO_X64_DEVICE:
# mimic JAX default: no float64, no int64
return {
"real floating": float32,
"complex floating": complex64,
"integral": int32,
"indexing": int32,
}
elif device == Device('device2'):
# mimic a torch CPU device: support float64 but default to float32
return {
Expand All @@ -107,6 +118,9 @@ def device_supports_dtype(device: Device | None, dtype: DType |None) -> bool:
# Device("no_float64") supports all dtypes except float64 and complex128
if device == NO_FLOAT64_DEVICE:
return dtype not in (float64, complex128)
if device == NO_X64_DEVICE:
# "no_x64" only supports 32-bit ints and floats
return dtype not in (float64, complex128, int64, uint64)

# All other devices support all dtypes
return True
Expand Down
13 changes: 12 additions & 1 deletion array_api_strict/tests/test_creation_functions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
zeros,
zeros_like,
)
from .._dtypes import float32, float64, complex64, bool as xp_bool
from .._dtypes import float32, float64, complex64, int32, int64, bool as xp_bool
from .._array_object import Array
from .._devices import CPU_DEVICE, ALL_DEVICES, Device
from .._info import __array_namespace_info__
Expand Down Expand Up @@ -375,6 +375,17 @@ def test_asarray_device_1():
assert y.dtype == float32


def test_asarray_no_x64_device():
x = asarray(3, device=Device("no_x64"))
assert x.dtype == int32

with pytest.raises(ValueError):
asarray(3, device=Device("no_x64"), dtype=int64)

y = zeros_like(ones(3, dtype=int32), device=Device("no_x64"))
assert y.dtype == int32


@pytest.mark.parametrize("api_version", ['2021.12', '2022.12', '2023.12'])
def from_dlpack_2023_12(api_version):
if api_version != '2022.12':
Expand Down
Loading