Skip to content

Normalize jobs PyDABs acceptance surface and drop coverage exception - #6548

Open
Sankalp-Mittal wants to merge 1 commit into
sankalp-mittal/pydabs-generate-all-resourcesfrom
sankalp-mittal/pydabs-jobs-tests-normalize
Open

Normalize jobs PyDABs acceptance surface and drop coverage exception#6548
Sankalp-Mittal wants to merge 1 commit into
sankalp-mittal/pydabs-generate-all-resourcesfrom
sankalp-mittal/pydabs-jobs-tests-normalize

Conversation

@Sankalp-Mittal

@Sankalp-Mittal Sankalp-Mittal commented Sep 7, 2026

Copy link
Copy Markdown
Collaborator

Summary

Stacked on top of #6528.

test_python_support_coverage requires every PyDABs resource to have an acceptance/bundle/python/<plural>-support/ fixture. jobs was the lone exception: it predates the <plural>-support convention and was carried in a _LACKING shrink-only allowlist ("covered across the suite instead").

This PR covers that gap by:

  • adding jobs-support test
  • removing the _LACKING allowlist

Testing

  • go test ./acceptance -run 'TestAccept/bundle/python/jobs-support' passes without -update across all four variants (both engines × both wheel versions) — deterministic.
  • test_python_support_coverage passes for all 23 resources with no exceptions.

This pull request and its description were written by Isaac.

Add the standard jobs-support/ fixture so jobs matches every other PyDABs
resource, then remove the _LACKING exception list from
test_python_support_coverage. The guard now uniformly requires a
<plural>-support/ fixture for every resource.

Co-authored-by: Isaac <no-reply@databricks.com>
@github-actions

github-actions Bot commented Sep 7, 2026

Copy link
Copy Markdown
Contributor

Approval status: pending

/acceptance/bundle/ - needs approval

6 files changed
Eligible: @andrewnester, @anton-107, @denik, @janniklasrose, @lennartkats-db, @pietern, @shreyas-goenka

General files (require maintainer)

Files: python/databricks_tests/core/test_python_support.py
Pick a maintainer from OWNERS.

Any maintainer (@andrewnester, @anton-107, @denik, @pietern, @shreyas-goenka, @simonfaltum, @renaudhartert-db, @janniklasrose, @lennartkats-db, @rugpanov, @rclarey) can approve all areas.
See OWNERS for ownership rules.

@Sankalp-Mittal
Sankalp-Mittal marked this pull request as draft September 7, 2026 13:10
@Sankalp-Mittal
Sankalp-Mittal marked this pull request as ready for review September 7, 2026 13:16
@eng-dev-ecosystem-bot

Copy link
Copy Markdown
Collaborator

Integration test report

Commit: db909a0

Run: 34125761940

Env 🔄​flaky 💚​RECOVERED 🙈​SKIP ✅​pass 🙈​skip Time
💚​ aws linux 1 1 274 1238 9:07
💚​ aws windows 1 1 276 1236 8:48
💚​ azure linux 1 1 273 1238 11:10
🔄​ azure windows 1 1 1 274 1236 10:30
💚​ gcp linux 1 1 274 1238 12:32
🔄​ gcp windows 1 1 1 275 1236 11:01
Test Name aws linux aws windows azure linux azure windows gcp linux gcp windows
💚​ TestAccept 💚​R 💚​R 💚​R 💚​R 💚​R 💚​R
🙈​ TestAccept/ssh/connection 🙈​S 🙈​S 🙈​S 🙈​S 🙈​S 🙈​S
🔄​ TestSyncFullFileSync ✅​p ✅​p ✅​p 🔄​f ✅​p ✅​p
🔄​ TestSyncIncrementalSyncPythonNotebookToFile ✅​p ✅​p ✅​p ✅​p ✅​p 🔄​f
Top 11 slowest tests (at least 2 minutes):
duration env testname
8:47 azure windows TestAccept
8:43 aws windows TestAccept
7:25 gcp windows TestAccept
4:02 aws linux TestAccept
4:02 gcp linux TestAccept
3:57 azure linux TestAccept
3:25 gcp windows TestFilerRecursiveDelete/workspace_files_extensions
2:36 azure windows TestFilerWorkspaceFilesExtensionsDelete
2:20 gcp windows TestFilerReadDir/workspace_files
2:01 azure windows TestFilerWorkspaceFilesExtensionsReadDir
2:01 gcp windows TestFilerWorkspaceFilesExtensionsReadDir

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants