Repository navigation
Conversation
For a working-tree snapshot, git ls-files silently ignores a pathspec that matches nothing, so a mistyped or stale include_paths entry was left out of the snapshot. The run then failed on the node after compute was provisioned. Commit-pinned snapshots already reject missing include_paths; working-tree snapshots now do the same before packaging. Co-authored-by: Isaac <no-reply@databricks.com>
Co-authored-by: Isaac <no-reply@databricks.com>
Contributor
|
Thanks for the contribution! This pull request was opened from a fork. If you're a member of the Databricks organization, please request access to the If you're an external contributor, no action is needed; a maintainer will review your pull request. |
Contributor
|
An authorized user can trigger integration tests manually by following the instructions below: Trigger: Inputs:
Checks will be approved automatically on success. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
air run: for a working-tree snapshot (nocode_source.git), rejectcode_source.include_pathsentries that select no files, and name them, before packaging. Commit-pinned snapshots already reject missing include paths. Entries with glob characters are left to git, since it matches them as patterns.Why
git ls-filesignores a pathspec that matches nothing, so a mistyped or stale entry was dropped from the snapshot without a warning,--dry-runpassed, and the run failed on the node after compute was provisioned. A realistic case is the AI Runtime cookbook's getting-started Ray recipes, which list the shared bootstrap and the recipe directory ininclude_paths:include_paths: [ray_bootstrap.sh, my_job]for amy-jobdirectory uploaded onlyray_bootstrap.sh.Tests
TestSnapshotFiles_RejectsIncludePathMatchingNothingAlongsideOthers: one valid and one mistyped entry; the error names only the mistyped one.TestSnapshotFiles_RejectsIncludePathWhoseFilesAreIgnored: an entry whose files are all git-ignored is rejected with thecheck-ignorehint.TestSnapshotFiles_AcceptsIncludePathForms:./src/, a file, and a glob are accepted and select the expected files.go test ./cmd/air/...andgo test ./acceptance -run TestAccept/airpass;golangci-lint run ./cmd/air/...reports no issues.TestLogsCommandRepeatsRunLinkAfterStreamingfails onmaintoo whenDATABRICKS_WORKSPACE_IDis exported in the shell (it adds?o=<id>to the expected link); it passes with the variable unset.This pull request and its description were written by Isaac.