Skip to content

acc: tolerate retried GET in postgres_endpoints/update_autoscaling - #7641

Open
denik wants to merge 1 commit into
mainfrom
acc-pg-endpoint-autoscaling-unique
Open

denik wants to merge 1 commit into
mainfrom
acc-pg-endpoint-autoscaling-unique

Conversation

@denik

@denik denik commented Nov 15, 2026

Copy link
Copy Markdown
Contributor

Changes

Record postgres requests with print_requests.py --unique in bundle/resources/postgres_endpoints/update_autoscaling, so a retried request (an identical consecutive request) is recorded once.

Why

On GCP the backend returned a transient 500 for GET .../branches/main during the no-change deploy. The CLI retried the read on purpose (libs/retry, IsTransientRead in bundle/direct), and the retry showed up as an extra request in out.requests.no_change.json. The retry is correct behavior, so the recording should tolerate it. Same approach as #7511 and #7547 for apps.

Not a regression from #7557 (that change retries create-operation polling) or from #7596 (testserver spec echo). The failing request is a plain remote-state read that has been retried for a while.

The current goldens have no consecutive duplicate requests, so --unique changes only the traced command line in output.txt.

Dashboard

Suppressed from output.txt:
    Warn: retrying after 500 Internal Server Error from GET /api/2.0/postgres/projects/test-pg-proj-[UNIQUE_NAME]/branches/main
...
+{
+  "method": "GET",
+  "path": "/api/2.0/postgres/projects/test-pg-proj-[UNIQUE_NAME]/branches/main"
+}
Messages: bundle/resources/postgres_endpoints/update_autoscaling/out.requests.no_change.json

Tests

Passed locally and on AWS (both DMS variants). The last commit asks CI to run the test on GCP and AWS.

This pull request and its description were written by Isaac.

gcp: TestAccept/bundle/resources/postgres_endpoints/update_autoscaling
aws: TestAccept/bundle/resources/postgres_endpoints/update_autoscaling

Co-authored-by: Isaac <no-reply@databricks.com>
@denik denik added the ai-auto PRs made by AI loops & factories, label Nov 15, 2026
@github-actions github-actions Bot added DABs DABs related issues test-only-fix PRs that update failing of flaky tests without changing CLI code. labels Nov 15, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Commit: 1724e8b79 | Workflow run

Regression test report

Selected 1 changed tests (limit=20, 0 not selected)

2 tests: regression=0 unreleased=0 coverage=2 failing=0
test branch main (2699068) latest (v1.26.0)
TestAccept/bundle/resources/postgres_endpoints/update_autoscaling/DMS= ✅ ✅ ✅
TestAccept/bundle/resources/postgres_endpoints/update_autoscaling/DMS=true ✅ ✅ ✅

@eng-dev-ecosystem-bot

Copy link
Copy Markdown
Collaborator

✅ Integration test report

Commit: 1724e8b

Run: 43673937942

Env ✅​pass 🙈​skip Time
✅​ aws linux-2core-8gb 274 15 3:54
✅​ aws-windows-latest-4core-16gb 276 13 3:54
✅​ azure linux-2core-8gb 273 15 4:04
✅​ azure-windows-latest-4core-16gb 275 13 3:57
✅​ gcp linux-2core-8gb 274 15 3:51
✅​ gcp-windows-latest-4core-16gb 276 13 3:46
Top 3 slowest tests (at least 2 minutes):
duration env testname
2:46 gcp-windows-latest-4core-16gb TestAccept
2:45 azure-windows-latest-4core-16gb TestAccept
2:33 aws-windows-latest-4core-16gb TestAccept

@denik
denik marked this pull request as ready for review November 15, 2026 04:10
@denik
denik requested review from a team as code owners November 15, 2026 04:10
@denik
denik enabled auto-merge November 15, 2026 04:37
@denik
denik requested a review from andrewnester November 15, 2026 04:37

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ai-auto PRs made by AI loops & factories, DABs DABs related issues test-only-fix PRs that update failing of flaky tests without changing CLI code.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants