Repository navigation
changelog: Add entry for the boolean flag help change from the pflag 1.1.0 bump - #7683
Closed
janniklasrose wants to merge 2 commits into
Closed
janniklasrose wants to merge 2 commits into
janniklasrose wants to merge 2 commits into
Conversation
…1.1.0 bump #7635 bumped pflag to 1.1.0 without a changelog entry. Its user-visible effect is that help output now shows `[=true|false]` after boolean flags. The entry also notes that the last occurrence of a repeated boolean flag wins, which the new help syntax makes discoverable. Co-authored-by: Isaac <no-reply@databricks.com>
Contributor
|
This was already the case. The bump only added it to the help output. I don't think this warrants a changelog entry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Add a
.nextchanges/cli/fragment for the user-visible effect of the pflag 1.1.0 bump in #7635: boolean flags now show[=true|false]in help output, and when a boolean flag is passed more than once, the last occurrence wins.Why
#7635 was a dependabot PR and merged without a changelog entry; the review asked for one. Parsing of
--flag=falseis not new in pflag 1.1.0, only the help rendering is (spf13/pflag#453), so the entry describes the help change and the existing last-occurrence-wins behavior rather than claiming new parsing.Tests
task check-changelogpasses locally.main:databricks version --debug --debug=falseprints no debug logs,databricks version --debug=false --debugdoes, anddatabricks --helpshows--debug[=true|false].This pull request and its description were written by Isaac.