Repository navigation
Conversation
pietern
force-pushed
the
pietern/charm-v2/03b-teainput
branch
from
November 17, 2026 22:29
e98f3d3 to
786e293
Compare
Collaborator
✅ Integration test reportCommit: abd2eff
Top 37 slowest tests (at least 2 minutes):
|
Contributor
Author
|
/review |
pietern
force-pushed
the
pietern/charm-v2/03b-teainput
branch
from
November 18, 2026 13:07
786e293 to
abd2eff
Compare
pietern
force-pushed
the
pietern/charm-v2/03b-teainput
branch
from
November 18, 2026 15:55
abd2eff to
6faf163
Compare
Models switch on keystroke names from teainput.Decode instead of v1 key types. Behaviour is v1's, with one fix: several runes arriving in one read are text and carry no key name, so typing "enter" fast no longer submits a prompt. A single rune is still a key press. Alt is kept in the name only where v1 checked it: Alt+rune, Alt+space, Alt+backspace and Alt+tab stay inert, and Alt+space still advances the pager. Other Alt combinations act as the plain key, as in v1. A paste is handled as v1 handled it: prompt inserts it, select treats it as typed text, and the pager ignores it. The existing burst pins (prompt "enter", select "down") and the new teainput tests pin the text. No golden moves. Co-authored-by: Isaac <no-reply@databricks.com>
pietern
force-pushed
the
pietern/charm-v2/03b-teainput
branch
from
November 18, 2026 16:07
6faf163 to
bc4d7d7
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Prompt, select and the pager switch on keystroke names from a new
libs/cmdio/teainputpackage instead of v1 key types:teainput.Decodeturns a bubbletea message into anEventwithKey(keystroke name),Text(printable text) andPaste. Key names follow bubbletea v2 (enter,ctrl+c,space,alt+backspace).Why
This is v1 behaviour on the new decoder, so the v2 move only changes the decoder. Fixed on the way: a burst of text that spells a key name (
enter,down) used to act as that key. v1 typed it as text; the decoder had given it the key's name, so a fastentersubmitted a prompt. Now a burst is text.Tests
go build ./..., golangci-lint (0 issues), gofmt clean.TERM=xterm-256color go test -race -count=3 ./libs/cmdio/...passes.teainputtests cover the decoder, including bursts (enter,down,ctrl+c) and paste.TestKeysPin_PromptBurstKeyName,TestKeysPin_SelectFilterBurstKeyName) pass with the same text as v1.-update. No golden changes.Stack: based on
pietern/charm-v2/03a-render-split.Manual checks for real terminals:
databricks selftest tui prompt, then typeenterquickly (or paste it) and press Enter:Entered: enter(v1 and this branch).This pull request and its description were written by Isaac.