Repository navigation
Prepare bundle bindings in memory before approval - #7765
Draft
shreyas-goenka wants to merge 1 commit into
Draft
shreyas-goenka wants to merge 1 commit into
shreyas-goenka wants to merge 1 commit into
Conversation
This was referenced Nov 18, 2026
Contributor
|
Commit: Regression test reportSelected 15 changed tests (limit=20, 0 not selected) 20 tests: regression=18 unreleased=0 coverage=2 failing=0
TestAccept/bundle/deployment/bind/dashboard/recreation/DMS=/READPLAN=: branch ✅ | main (4c87e6a) ❌ | latest (v1.26.0) ❌main (4c87e6a): latest (v1.26.0): same output as main (4c87e6a) TestAccept/bundle/deployment/bind/dashboard/recreation/DMS=/READPLAN=1: branch ✅ | main (4c87e6a) ❌ | latest (v1.26.0) ❌main (4c87e6a): latest (v1.26.0): same output as main (4c87e6a) TestAccept/bundle/deployment/bind/dashboard/recreation/DMS=true/READPLAN=: branch ✅ | main (4c87e6a) ❌ | latest (v1.26.0) ❌main (4c87e6a): latest (v1.26.0): same output as main (4c87e6a) TestAccept/bundle/deployment/bind/dashboard/recreation/DMS=true/READPLAN=1: branch ✅ | main (4c87e6a) ❌ | latest (v1.26.0) ❌main (4c87e6a): latest (v1.26.0): same output as main (4c87e6a) TestAccept/bundle/deployment/bind/job/noop-job/DMS=: branch ✅ | main (4c87e6a) ❌ | latest (v1.26.0) ❌main (4c87e6a): latest (v1.26.0): same output as main (4c87e6a) TestAccept/bundle/deployment/bind/job/noop-job/DMS=true: branch ✅ | main (4c87e6a) ❌ | latest (v1.26.0) ❌main (4c87e6a): latest (v1.26.0): TestAccept/bundle/dms_fault/complete_version/DMS=true: branch ✅ | main (4c87e6a) ❌ | latest (v1.26.0) ❌main (4c87e6a): latest (v1.26.0): TestAccept/bundle/dms_fault/delete_deployment/DMS=true: branch ✅ | main (4c87e6a) ❌ | latest (v1.26.0) ❌main (4c87e6a): latest (v1.26.0): 10 more failure details omitted, see the full report in the run. |
Collaborator
✅ Integration test reportCommit: 8254700
Top 50 slowest tests (at least 2 minutes):
|
shreyas-goenka
force-pushed
the
shreyas-goenka_data/shreyas-goenka/bind-prepare-state
branch
2 times, most recently
from
November 18, 2026 14:25
6ee418c to
758f928
Compare
shreyas-goenka
force-pushed
the
shreyas-goenka_data/shreyas-goenka/bind-prepare-state
branch
from
November 18, 2026 14:35
758f928 to
8254700
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
bundle deployment bindcurrently writes temporary state twice before asking for approval. Prepare both planning passes in isolated memory, then persist the approved binding through one StateDB transaction.This removes temporary binding files and changes the usual state serial increment from two to one. Resource previews, reference resolution, and approval behavior are preserved. This is the preparation layer beneath the deployment-history PRs.
Validation
Stack: this PR → shared DMS helpers #7766 → bind history #7400 → unbind history #7401.
This PR was written by Codex.