Skip to content

direct: use the postgres role a failed create request created - #7767

Open
denik wants to merge 2 commits into
mainfrom
denik/postgres-role-create-recovery
Open

denik wants to merge 2 commits into
mainfrom
denik/postgres-role-create-recovery

Conversation

@denik

@denik denik commented Nov 18, 2026 •

Copy link
Copy Markdown
Contributor

Changes

When the request to create a postgres role fails with a transient error (5xx, 408, inactivity timeout), the direct engine now looks for the role before giving up, using the look-then-repeat loop branches (#7602) and projects (#7747) already use (recoverPostgresCreate):

  • The role exists and our request created it (by create_time, allowing a minute of clock skew): use it, logged at Info.
  • The role exists but predates our first request: fail with the original error plus role ... exists but was not created by this deployment. It isn't taken over.
  • The role is missing: pause for the standard retry interval (with the usual retrying after ... warning), then repeat the create, up to retry.MaxRetries times. A repeat that fails with ALREADY_EXISTS goes back to the lookup.
  • replace_existing: true: the error is marked retrySafe, and DeploymentUnit.Create repeats the create without reading the role, as for branches.
  • A read that fails returns the original create error, with the read error as a warning.

Judgment calls:

  • Roles have no ready state, so a found role is used as is, with no wait.
  • An inherited role on a child branch is not taken over by the one-minute skew in the usual case. On AWS, a role inherited by a new child branch reports its parent role's create_time, not the child branch's. It falls inside the window only if the parent role was created less than a minute before this create request, and the request also fails with a transient error.

Why

On every cloud, the role create request made right after a new branch is created is answered with a 500 now and then. Nothing retried it, so the deploy failed, and so did every database that depends on the role. This happened 6 times in 7 days on AWS, Azure and GCP, on main and in PRs.

Dashboard:

error snippet
error/529 Error: cannot create resources.postgres_roles.owner: The request could not be processed. Please try again later and contact Databricks if the problem persists. [TraceId: [TRACE_ID]] (500 INTERNAL_ERROR) on POST [DATABRICKS_URL]/api/2.0/postgres/projects/test-pg-proj-[UNIQUE_NAME]/branches/main/roles?role_id=app-owner

Tests: postgres_databases/replace_existing/DMS=, postgres_databases/basic/DMS=, postgres_databases/recreate/DMS=, postgres_projects/update_keeps_children/DMS=true.

Tests

  • New unit tests in bundle/direct/dresources/postgres_role_test.go drive DoCreate against a testserver with scripted responses: the role is found and used; missing, then a successful repeat; missing, then a repeat that gets the API's 400 "role with that name already exists", then the role is found; missing on every attempt; a role that predates the request; a failed read; replace_existing; a non-transient error (no read). All but the last fail without the change.
  • New local acceptance test bundle/resources/postgres_roles/create_transient_500: the role was created despite the 500 and is used; it was not created and the create is repeated; the read fails and the deploy fails with the original error; replace_existing repeats the create without a read.
  • The local bundle/resources/postgres_* acceptance tests and the bundle/direct/... unit tests pass.
  • The last commit asks CI to run postgres_roles, postgres_databases/basic and postgres_databases/replace_existing on every cloud.

This pull request and its description were written by Isaac.

When the request to create a postgres role fails with a transient error,
look for the role before repeating the request, as branches and projects
already do.

cloud: TestAccept/bundle/resources/postgres_roles TestAccept/bundle/resources/postgres_databases/basic TestAccept/bundle/resources/postgres_databases/replace_existing

Co-authored-by: Isaac <no-reply@databricks.com>
@denik denik added the ai-auto PRs made by AI loops & factories, label Nov 18, 2026
@github-actions github-actions Bot added the DABs DABs related issues label Nov 18, 2026
@github-actions

github-actions Bot commented Nov 18, 2026 •

Copy link
Copy Markdown
Contributor

Commit: 18fcdb8da | Workflow run

Regression test report

Selected 1 changed tests (limit=20, 0 not selected)

18 tests: regression=2 unreleased=0 coverage=16 failing=0
test branch main (61f1fc5) latest (v1.26.0)
TestAccept/bundle/resources/postgres_databases/basic/DMS= ✅ ✅ ✅
TestAccept/bundle/resources/postgres_databases/basic/DMS=true ✅ ✅ ✅
TestAccept/bundle/resources/postgres_roles/basic/DMS= ✅ ✅ ✅
TestAccept/bundle/resources/postgres_roles/basic/DMS=true ✅ ✅ ✅
TestAccept/bundle/resources/postgres_roles/create_transient_500/DMS= ✅ ❌ ❌
TestAccept/bundle/resources/postgres_roles/create_transient_500/DMS=true ✅ ❌ ❌
TestAccept/bundle/resources/postgres_roles/inherited-role-bind/DMS= ✅ ✅ ✅
TestAccept/bundle/resources/postgres_roles/inherited-role-bind/DMS=true ✅ ✅ ✅
TestAccept/bundle/resources/postgres_roles/inherited-role-conflict/DMS= ✅ ✅ ✅
TestAccept/bundle/resources/postgres_roles/inherited-role-conflict/DMS=true ✅ ✅ ✅
TestAccept/bundle/resources/postgres_roles/recreate-postgres-role/DMS= ✅ ✅ ✅
TestAccept/bundle/resources/postgres_roles/recreate-postgres-role/DMS=true ✅ ✅ ✅
TestAccept/bundle/resources/postgres_roles/recreate/DMS= ✅ ✅ ✅
TestAccept/bundle/resources/postgres_roles/recreate/DMS=true ✅ ✅ ✅
TestAccept/bundle/resources/postgres_roles/replace_existing/DMS= ✅ ✅ ✅
TestAccept/bundle/resources/postgres_roles/replace_existing/DMS=true ✅ ✅ ✅
TestAccept/bundle/resources/postgres_roles/update/DMS= ✅ ✅ ✅
TestAccept/bundle/resources/postgres_roles/update/DMS=true ✅ ✅ ✅
TestAccept/bundle/resources/postgres_roles/create_transient_500/DMS=: branch ✅ | main (61f1fc5) ❌ | latest (v1.26.0) ❌

main (61f1fc5):

acceptance_test.go:1388: Diff:
        --- bundle/resources/postgres_roles/create_transient_500/output.txt
        +++ /tmp/TestAcceptbundleresourcespostgres_rolescreate_transient_500983904410/002/output.txt
        @@ -5,38 +5,6 @@
         Uploading bundle files to /Workspace/Users/[USERNAME]/.bundle/test-bundle/default/files...
         Created postgres_branches.main
         Created postgres_projects.my_project
        -Created postgres_roles.owner
        -Files: 0 uploaded, 0 deleted
        -Resources: 3 created, 0 changed, 0 deleted, 0 unchanged
        -
        ->>> print_requests.py --get //postgres/projects/test-pg-proj/branches/main/roles
        -POST /api/2.0/postgres/projects/test-pg-proj/branches/main/roles
        -GET /api/2.0/postgres/projects/test-pg-proj/branches/main/roles/app-owner
        -
        -=== The create request fails with 500 and the role was not created: deploy repeats the create
        -
        ->>> [CLI] bundle deploy
        -Uploading bundle files to /Workspace/Users/[USERNAME]/.bundle/test-bundle/default/files...
        -Created postgres_branches.main
        -Created postgres_projects.my_project
        -Warn: deploying resources.postgres_roles.owner: retrying after 500 Internal Server Error from POST /api/2.0/postgres/projects/test-pg-proj/branches/main/roles
        -Created postgres_roles.owner
        -Files: 0 uploaded, 0 deleted
        -Resources: 3 created, 0 changed, 0 deleted, 0 unchanged
        -
        ->>> print_requests.py --get //postgres/projects/test-pg-proj/branches/main/roles
        -POST /api/2.0/postgres/projects/test-pg-proj/branches/main/roles
        -GET /api/2.0/postgres/projects/test-pg-proj/branches/main/roles/app-owner
        -POST /api/2.0/postgres/projects/test-pg-proj/branches/main/roles
        -GET /api/2.0/postgres/projects/test-pg-proj/branches/main/roles/app-owner/operations/[UUID][0]
        -
        -=== The role cannot be read after the create request fails: deploy fails with the create error
        -
        ->>> musterr [CLI] bundle deploy
        -Uploading bundle files to /Workspace/Users/[USERNAME]/.bundle/test-bundle/default/files...
        -Created postgres_branches.main
        -Created postgres_projects.my_project
        -Warn: deploying resources.postgres_roles.owner: checking whether projects/test-pg-proj/branches/main/roles/app-owner was created: Fault injected by test.
         Error: cannot create resources.postgres_roles.owner: Fault injected by test. (500 INTERNAL_ERROR)
         
         Endpoint: POST [DATABRICKS_URL]/api/2.0/postgres/projects/test-pg-proj/branches/main/roles?role_id=app-owner
        @@ -46,22 +14,4 @@
         
         Files: 0 uploaded, 0 deleted
         
        ->>> print_requests.py --get //postgres/projects/test-pg-proj/branches/main/roles
        -POST /api/2.0/postgres/projects/test-pg-proj/branches/main/roles
        -GET /api/2.0/postgres/projects/test-pg-proj/branches/main/roles/app-owner
        -
        -=== With replace_existing, a failed create request is repeated without reading the role
        -
        ->>> [CLI] bundle deploy
        -Uploading bundle files to /Workspace/Users/[USERNAME]/.bundle/test-bundle/default/files...
        -Created postgres_branches.main
        -Created postgres_projects.my_project
        -Warn: deploying resources.postgres_roles.owner: retrying after 500 Internal Server Error from POST /api/2.0/postgres/projects/test-pg-proj/branches/main/roles
        -Created postgres_roles.owner
        -Files: 0 uploaded, 0 deleted
        -Resources: 3 created, 0 changed, 0 deleted, 0 unchanged
        -
        ->>> print_requests.py --get //postgres/projects/test-pg-proj/branches/main/roles
        -POST /api/2.0/postgres/projects/test-pg-proj/branches/main/roles
        -POST /api/2.0/postgres/projects/test-pg-proj/branches/main/roles
        -GET /api/2.0/postgres/projects/test-pg-proj/branches/main/roles/app-owner/operations/[UUID][1]
        +Exit code: 1

latest (v1.26.0): same output as main (61f1fc5)

TestAccept/bundle/resources/postgres_roles/create_transient_500/DMS=true: branch ✅ | main (61f1fc5) ❌ | latest (v1.26.0) ❌

main (61f1fc5):

acceptance_test.go:1388: Diff:
        --- bundle/resources/postgres_roles/create_transient_500/output.txt
        +++ /tmp/TestAcceptbundleresourcespostgres_rolescreate_transient_5002288478318/002/output.txt
        @@ -5,38 +5,6 @@
         Uploading bundle files to /Workspace/Users/[USERNAME]/.bundle/test-bundle/default/files...
         Created postgres_branches.main
         Created postgres_projects.my_project
        -Created postgres_roles.owner
        -Files: 0 uploaded, 0 deleted
        -Resources: 3 created, 0 changed, 0 deleted, 0 unchanged
        -
        ->>> print_requests.py --get //postgres/projects/test-pg-proj/branches/main/roles
        -POST /api/2.0/postgres/projects/test-pg-proj/branches/main/roles
        -GET /api/2.0/postgres/projects/test-pg-proj/branches/main/roles/app-owner
        -
        -=== The create request fails with 500 and the role was not created: deploy repeats the create
        -
        ->>> [CLI] bundle deploy
        -Uploading bundle files to /Workspace/Users/[USERNAME]/.bundle/test-bundle/default/files...
        -Created postgres_branches.main
        -Created postgres_projects.my_project
        -Warn: deploying resources.postgres_roles.owner: retrying after 500 Internal Server Error from POST /api/2.0/postgres/projects/test-pg-proj/branches/main/roles
        -Created postgres_roles.owner
        -Files: 0 uploaded, 0 deleted
        -Resources: 3 created, 0 changed, 0 deleted, 0 unchanged
        -
        ->>> print_requests.py --get //postgres/projects/test-pg-proj/branches/main/roles
        -POST /api/2.0/postgres/projects/test-pg-proj/branches/main/roles
        -GET /api/2.0/postgres/projects/test-pg-proj/branches/main/roles/app-owner
        -POST /api/2.0/postgres/projects/test-pg-proj/branches/main/roles
        -GET /api/2.0/postgres/projects/test-pg-proj/branches/main/roles/app-owner/operations/[UUID][0]
        -
        -=== The role cannot be read after the create request fails: deploy fails with the create error
        -
        ->>> musterr [CLI] bundle deploy
        -Uploading bundle files to /Workspace/Users/[USERNAME]/.bundle/test-bundle/default/files...
        -Created postgres_branches.main
        -Created postgres_projects.my_project
        -Warn: deploying resources.postgres_roles.owner: checking whether projects/test-pg-proj/branches/main/roles/app-owner was created: Fault injected by test.
         Error: cannot create resources.postgres_roles.owner: Fault injected by test. (500 INTERNAL_ERROR)
         
         Endpoint: POST [DATABRICKS_URL]/api/2.0/postgres/projects/test-pg-proj/branches/main/roles?role_id=app-owner
        @@ -46,22 +14,4 @@
         
         Files: 0 uploaded, 0 deleted
         
        ->>> print_requests.py --get //postgres/projects/test-pg-proj/branches/main/roles
        -POST /api/2.0/postgres/projects/test-pg-proj/branches/main/roles
        -GET /api/2.0/postgres/projects/test-pg-proj/branches/main/roles/app-owner
        -
        -=== With replace_existing, a failed create request is repeated without reading the role
        -
        ->>> [CLI] bundle deploy
        -Uploading bundle files to /Workspace/Users/[USERNAME]/.bundle/test-bundle/default/files...
        -Created postgres_branches.main
        -Created postgres_projects.my_project
        -Warn: deploying resources.postgres_roles.owner: retrying after 500 Internal Server Error from POST /api/2.0/postgres/projects/test-pg-proj/branches/main/roles
        -Created postgres_roles.owner
        -Files: 0 uploaded, 0 deleted
        -Resources: 3 created, 0 changed, 0 deleted, 0 unchanged
        -
        ->>> print_requests.py --get //postgres/projects/test-pg-proj/branches/main/roles
        -POST /api/2.0/postgres/projects/test-pg-proj/branches/main/roles
        -POST /api/2.0/postgres/projects/test-pg-proj/branches/main/roles
        -GET /api/2.0/postgres/projects/test-pg-proj/branches/main/roles/app-owner/operations/[UUID][1]
        +Exit code: 1

latest (v1.26.0):

acceptance_test.go:1388: Diff:
        --- bundle/resources/postgres_roles/create_transient_500/output.txt
        +++ /tmp/TestAcceptbundleresourcespostgres_rolescreate_transient_500375864357/002/output.txt
        @@ -5,38 +5,6 @@
         Uploading bundle files to /Workspace/Users/[USERNAME]/.bundle/test-bundle/default/files...
         Created postgres_branches.main
         Created postgres_projects.my_project
        -Created postgres_roles.owner
        -Files: 0 uploaded, 0 deleted
        -Resources: 3 created, 0 changed, 0 deleted, 0 unchanged
        -
        ->>> print_requests.py --get //postgres/projects/test-pg-proj/branches/main/roles
        -POST /api/2.0/postgres/projects/test-pg-proj/branches/main/roles
        -GET /api/2.0/postgres/projects/test-pg-proj/branches/main/roles/app-owner
        -
        -=== The create request fails with 500 and the role was not created: deploy repeats the create
        -
        ->>> [CLI] bundle deploy
        -Uploading bundle files to /Workspace/Users/[USERNAME]/.bundle/test-bundle/default/files...
        -Created postgres_branches.main
        -Created postgres_projects.my_project
        -Warn: deploying resources.postgres_roles.owner: retrying after 500 Internal Server Error from POST /api/2.0/postgres/projects/test-pg-proj/branches/main/roles
        -Created postgres_roles.owner
        -Files: 0 uploaded, 0 deleted
        -Resources: 3 created, 0 changed, 0 deleted, 0 unchanged
        -
        ->>> print_requests.py --get //postgres/projects/test-pg-proj/branches/main/roles
        -POST /api/2.0/postgres/projects/test-pg-proj/branches/main/roles
        -GET /api/2.0/postgres/projects/test-pg-proj/branches/main/roles/app-owner
        -POST /api/2.0/postgres/projects/test-pg-proj/branches/main/roles
        -GET /api/2.0/postgres/projects/test-pg-proj/branches/main/roles/app-owner/operations/[UUID][0]
        -
        -=== The role cannot be read after the create request fails: deploy fails with the create error
        -
        ->>> musterr [CLI] bundle deploy
        -Uploading bundle files to /Workspace/Users/[USERNAME]/.bundle/test-bundle/default/files...
        -Created postgres_branches.main
        -Created postgres_projects.my_project
        -Warn: deploying resources.postgres_roles.owner: checking whether projects/test-pg-proj/branches/main/roles/app-owner was created: Fault injected by test.
         Error: cannot create resources.postgres_roles.owner: Fault injected by test. (500 INTERNAL_ERROR)
         
         Endpoint: POST [DATABRICKS_URL]/api/2.0/postgres/projects/test-pg-proj/branches/main/roles?role_id=app-owner
        @@ -46,22 +14,4 @@
         
         Files: 0 uploaded, 0 deleted
         
        ->>> print_requests.py --get //postgres/projects/test-pg-proj/branches/main/roles
        -POST /api/2.0/postgres/projects/test-pg-proj/branches/main/roles
        -GET /api/2.0/postgres/projects/test-pg-proj/branches/main/roles/app-owner
        -
        -=== With replace_existing, a failed create request is repeated without reading the role
        -
        ->>> [CLI] bundle deploy
        -Uploading bundle files to /Workspace/Users/[USERNAME]/.bundle/test-bundle/default/files...
        -Created postgres_branches.main
        -Created postgres_projects.my_project
        -Warn: deploying resources.postgres_roles.owner: retrying after 500 Internal Server Error from POST /api/2.0/postgres/projects/test-pg-proj/branches/main/roles
        -Created postgres_roles.owner
        -Files: 0 uploaded, 0 deleted
        -Resources: 3 created, 0 changed, 0 deleted, 0 unchanged
        -
        ->>> print_requests.py --get //postgres/projects/test-pg-proj/branches/main/roles
        -POST /api/2.0/postgres/projects/test-pg-proj/branches/main/roles
        -POST /api/2.0/postgres/projects/test-pg-proj/branches/main/roles
        -GET /api/2.0/postgres/projects/test-pg-proj/branches/main/roles/app-owner/operations/[UUID][1]
        +Exit code: 1
        
FAIL

@eng-dev-ecosystem-bot

Copy link
Copy Markdown
Collaborator

✅ Integration test report

Commit: 09588af

Run: 44302774268

Env 💚​RECOVERED ✅​pass 🙈​skip Time
💚​ aws linux-2core-8gb 1 293 22 21:17
💚​ aws-windows-latest-4core-16gb 1 295 20 11:27
💚​ azure linux-2core-8gb 1 292 22 19:43
💚​ azure-windows-latest-4core-16gb 1 294 20 14:40
💚​ gcp linux-2core-8gb 1 293 22 16:37
💚​ gcp-windows-latest-4core-16gb 1 295 20 10:13
Test Name aws linux-2core-8gb aws-windows-latest-4core-16gb azure linux-2core-8gb azure-windows-latest-4core-16gb gcp linux-2core-8gb gcp-windows-latest-4core-16gb
💚​ TestAccept 💚​R 💚​R 💚​R 💚​R 💚​R 💚​R
Top 50 slowest tests (at least 2 minutes):
duration env testname
6:57 azure-windows-latest-4core-16gb TestAccept/bundle/resources/postgres_roles/update/DMS=
5:27 azure linux-2core-8gb TestAccept/bundle/resources/postgres_roles/update/DMS=
4:58 aws linux-2core-8gb TestAccept/bundle/resources/postgres_roles/recreate-postgres-role/DMS=
4:47 aws-windows-latest-4core-16gb TestAccept/bundle/resources/postgres_databases/replace_existing/DMS=true
4:42 gcp linux-2core-8gb TestAccept/bundle/resources/postgres_databases/basic/DMS=
4:11 aws linux-2core-8gb TestAccept/bundle/resources/postgres_roles/update/DMS=
4:07 azure linux-2core-8gb TestFilerWorkspaceFilesExtensionsStat
3:58 aws linux-2core-8gb TestAccept/bundle/resources/postgres_roles/update/DMS=true
3:57 azure linux-2core-8gb TestAccept/bundle/resources/postgres_roles/update/DMS=true
3:51 azure linux-2core-8gb TestAccept/bundle/resources/postgres_roles/replace_existing/DMS=true
3:48 azure-windows-latest-4core-16gb TestFilerReadDir/workspace_files
3:47 gcp-windows-latest-4core-16gb TestAccept/bundle/resources/postgres_roles/update/DMS=true
3:45 azure linux-2core-8gb TestAccept/bundle/resources/postgres_roles/recreate/DMS=
3:45 azure linux-2core-8gb TestAccept/bundle/resources/postgres_roles/recreate/DMS=true
3:43 azure-windows-latest-4core-16gb TestAccept/bundle/resources/postgres_roles/update/DMS=true
3:42 azure-windows-latest-4core-16gb TestAccept/bundle/resources/postgres_roles/recreate-postgres-role/DMS=true
3:42 aws linux-2core-8gb TestAccept/bundle/resources/postgres_databases/replace_existing/DMS=
3:40 azure-windows-latest-4core-16gb TestFilerWorkspaceFilesExtensionsStat
3:37 azure linux-2core-8gb TestAccept/bundle/resources/postgres_roles/recreate-postgres-role/DMS=true
3:37 aws-windows-latest-4core-16gb TestAccept/bundle/resources/postgres_roles/recreate-postgres-role/DMS=
3:35 azure linux-2core-8gb TestFilerWorkspaceFilesExtensionsReadDir
3:31 azure linux-2core-8gb TestImportDirWithOverwriteFlag
3:28 gcp-windows-latest-4core-16gb TestAccept
3:25 azure-windows-latest-4core-16gb TestAccept
3:22 aws-windows-latest-4core-16gb TestAccept
3:22 aws-windows-latest-4core-16gb TestAccept/bundle/resources/postgres_roles/update/DMS=
3:14 gcp-windows-latest-4core-16gb TestAccept/bundle/resources/postgres_roles/replace_existing/DMS=true
3:13 aws linux-2core-8gb TestSyncNestedFolderDoesntFailOnNonEmptyDirectory
3:11 azure-windows-latest-4core-16gb TestAccept/bundle/resources/postgres_roles/recreate/DMS=true
3:06 azure-windows-latest-4core-16gb TestExportDir
3:04 azure linux-2core-8gb TestFilerWorkspaceFilesExtensionsRead
3:03 azure-windows-latest-4core-16gb TestImportDirWithOverwriteFlag
3:03 azure linux-2core-8gb TestFilerWorkspaceNotebook/pythonJupyterNb.ipynb
2:59 aws linux-2core-8gb TestFilerRecursiveDelete/workspace_files_extensions
2:54 aws-windows-latest-4core-16gb TestAccept/bundle/resources/postgres_roles/recreate/DMS=
2:50 aws linux-2core-8gb TestLock
2:45 aws linux-2core-8gb TestAccept/bundle/resources/postgres_roles/replace_existing/DMS=true
2:43 azure linux-2core-8gb TestFilerRecursiveDelete/workspace_files
2:40 gcp-windows-latest-4core-16gb TestAccept/bundle/resources/postgres_roles/update/DMS=
2:30 azure-windows-latest-4core-16gb TestAccept/bundle/resources/postgres_databases/basic/DMS=true
2:27 azure-windows-latest-4core-16gb TestAccept/bundle/resources/postgres_databases/replace_existing/DMS=true
2:24 aws-windows-latest-4core-16gb TestAccept/bundle/resources/postgres_roles/update/DMS=true
2:24 azure-windows-latest-4core-16gb TestAccept/bundle/resources/postgres_roles/replace_existing/DMS=
2:20 aws linux-2core-8gb TestImportDirWithOverwriteFlag
2:16 azure-windows-latest-4core-16gb TestAccept/bundle/resources/postgres_databases/replace_existing/DMS=
2:14 gcp linux-2core-8gb TestAccept/bundle/resources/postgres_roles/update/DMS=
2:11 aws linux-2core-8gb TestAccept/bundle/resources/postgres_roles/basic/DMS=true
2:10 gcp-windows-latest-4core-16gb TestAccept/bundle/resources/postgres_databases/replace_existing/DMS=
2:09 gcp linux-2core-8gb TestAccept/bundle/resources/postgres_roles/update/DMS=true
2:08 azure-windows-latest-4core-16gb TestAccept/bundle/resources/postgres_roles/basic/DMS=true

@denik
denik marked this pull request as ready for review November 18, 2026 13:21
@denik
denik requested review from a team as code owners November 18, 2026 13:21
@denik
denik requested review from Sankalp-Mittal, andrewnester, janniklasrose and rugpanov and removed request for rugpanov November 18, 2026 13:21

@review-oss-bot review-oss-bot Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me — no issues found.

@Sankalp-Mittal Sankalp-Mittal left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[AI Generated] Review by review-factory (Claude Fable 5.2 + Claude Opus 5.5, cross-verified). Only points the reviewers agreed on are posted.

- Add .nextchanges/bundles/7767.md.
- The duplicate-role fixture uses the 400 BAD_REQUEST the API sends.
- The failing scenario asserts the failure with musterr; destroy output
  goes to LOG.destroy.

cloud: TestAccept/bundle/resources/postgres_roles TestAccept/bundle/resources/postgres_databases/basic

Co-authored-by: Isaac <no-reply@databricks.com>

@Sankalp-Mittal Sankalp-Mittal left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[AI Generated] Follow-up review by review-factory (Claude Fable 5.2 + Claude Opus 5.5, cross-verified). Only points the reviewers agreed on are posted.

No new issues found.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ai-auto PRs made by AI loops & factories, DABs DABs related issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants