ai: apply changes for #915 (1 review thread)

Addresses:
  - #3802314928 at src/databricks/sql/session.py:71

Signed-off-by: peco-engineer-bot[bot] <peco-engineer-bot[bot]@users.noreply.github.com>

Author: peco-engineer-bot[bot]

src/databricks/sql/session.py

@@ -37,7 +37,8 @@ def _kernel_host_and_path(
       (returned as ``host``) and its path+query (returned as ``http_path``).
       ``_connection_uri`` wins over ``_port``, matching the Thrift backend.
       When the URI omits a path (e.g. ``https://host:8443`` or
-      ``https://host:8443?o=222``) the connection's original ``http_path`` is
+      ``https://host:8443?o=222``, and likewise a lone trailing slash such as
+      ``https://host:8443/``) the connection's original ``http_path`` is
       retained, and any query on the URI is applied to that retained path,
       replacing any query the retained path already carried — so a path-less,
       query-bearing URI overrides only the host and query while keeping the
@@ -67,8 +68,12 @@ def _kernel_host_and_path(
         host = "{}://{}".format(parts.scheme, parts.netloc)
         # A path-less URI keeps the connection's original http_path; any query
         # on the URI is then applied to that retained path (host + query
-        # override, path preserved). See the docstring for the rationale.
-        path = parts.path or http_path
+        # override, path preserved). A lone ``"/"`` path (common from a
+        # copy-pasted base URL like ``https://host:8443/``) is treated the same
+        # as an absent path so it does not silently point the kernel at the host
+        # root instead of the warehouse. See the docstring for the rationale.
+        uri_path = parts.path if parts.path not in ("", "/") else None
+        path = uri_path or http_path
         if parts.query:
             # Drop any query already on the retained path before applying the
             # URI's query, so the URI's query fully overrides it. Appending

tests/unit/test_session.py

@@ -771,6 +771,26 @@ def test_connection_uri_without_path_retains_original_path(self):
         assert host == "https://h.example.com:8443"
         assert path == self.PATH
 
+    def test_connection_uri_trailing_slash_retains_original_path(self):
+        # A lone trailing slash (common when a base URL is copy-pasted, e.g.
+        # ``https://host:8443/``) must be treated the same as an absent path so
+        # the original warehouse http_path is retained rather than silently
+        # replaced with the host root ``"/"``.
+        host, path = _kernel_host_and_path(
+            self.HOST, self.PATH, {"_connection_uri": "https://h.example.com:8443/"}
+        )
+        assert host == "https://h.example.com:8443"
+        assert path == self.PATH
+
+    def test_connection_uri_trailing_slash_applies_query_to_retained_path(self):
+        # A trailing-slash, query-bearing URI overrides the host and applies the
+        # query to the retained original path, just like the path-less case.
+        host, path = _kernel_host_and_path(
+            self.HOST, self.PATH, {"_connection_uri": "https://h.example.com:8443/?o=222"}
+        )
+        assert host == "https://h.example.com:8443"
+        assert path == "{}?o=222".format(self.PATH)
+
     def test_connection_uri_without_path_applies_query_to_retained_path(self):
         # A path-less, query-bearing URI overrides the host and applies the
         # query to the retained original path (documented fallback semantics).