Implement Card Content Scroll Threshold#404
Merged
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors the scroll detection in the CardContent component by replacing the custom useCachedResizeValues hook with a local ResizeObserver and useEffect that manages a canScroll state. It also updates the SCSS to conditionally apply scrollbar styles. The review feedback correctly identifies that the ResizeObserver needs to observe the inner container to detect dynamic content changes, and that the hasScrolled state should be reset when the content is no longer scrollable.
nick-nlb
previously requested changes
Jul 16, 2026
beets
dismissed
nick-nlb’s stale review
July 22, 2026 04:36
Paulo has made the requested change and I've reviewed the update. LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket