Implement Ability To Drag Selection Actions Bar#414
Open
PauloMFJ wants to merge 3 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors the drag-handling logic by extracting the core dragging functionality into a reusable useShapeDragHandle hook, which is now utilized by both card and multi-selection drag handles. Additionally, selection positioning logic has been separated into its own hook. The review feedback highlights a TypeScript compilation issue under strict null checks when filtering shapes, recommending flatMap as a type-safe alternative. It also suggests using optional chaining for pointer capture methods to prevent potential runtime errors in testing environments like jsdom.
beets
approved these changes
Jul 21, 2026
Contributor
|
/cc @miss-o-soup for your thoughts on the z-index issue above. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Overview
updateShapes, history markers) into a reusableuseShapeDragHandlehook, and reduceuseCardDragHandleto a thin wrapper over it so the two paths no longer duplicate logic.Selectioninto its ownselection/folder and split it intouseSelectionPosition(presence + box placement) anduseSelectionDragHandlehooks, matching the card base's hook-per-concern structure.cursor: grabbingto usecursor: all-scrollto closer match tldraw behaviour.Ticket