chore: pin go.datum.net/network to local replace for Phase A egress types - #380
Open
privateip wants to merge 2 commits into
Open
chore: pin go.datum.net/network to local replace for Phase A egress types#380privateip wants to merge 2 commits into
privateip wants to merge 2 commits into
Conversation
…ypes Phase A of #865 (NAT masquerade egress). NetworkEgressPolicy and NetworkGatewayStatus.EgressAddress land in datum-cloud/network#15, not yet merged or tagged. A temporary replace directive points at the local checkout so this repo builds against the new types now; remove it once #15 merges and a tag is cut, then bump the require line to the real pseudo-version/tag. No consuming code yet — that's Phase C.
scotwells
previously approved these changes
Aug 13, 2026
datum-cloud/network#15 (NetworkEgressPolicy, NetworkGatewayStatus. EgressAddress) merged to main at 96677d6. Replace the local ../network replace directive from 35d009c with a real pseudo-version pinned to that commit; drop the replace now that it's no longer dev-only. No tag has been cut yet, so this is still a pseudo-version rather than a semver tag — bump to a tag once one exists. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
scotwells
approved these changes
Aug 14, 2026
scotwells
approved these changes
Aug 14, 2026
ecv
approved these changes
Aug 14, 2026
Contributor
|
Approved. Title and description are stale relative to the diff: they still describe a temporary |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Phase A of #865, per docs/plans/865-edge-gateway-nat66-egress.md §4.1.
replace go.datum.net/network => ../networkin go.mod, sothis repo builds against
NetworkEgressPolicy/NetworkGatewayStatus.EgressAddressbefore feat(api): add NetworkEgressPolicy and NetworkGatewayStatus.EgressAddress network#15merges and tags.
Depends on
datum-cloud/network#15 — merge and tag that first, then drop the
replace directive here and bump the require line to the real
pseudo-version.
Testing
go build ./...,go vet ./...— clean.task test:unit,task lint— all pass, 0 issues.🤖 Generated with Claude Code