fix(cni): grant galactic-cni get on network-attachment-definitions - #412
Merged
Conversation
d3c1ca3 (#331, chain completeness check) added a Get call on the pod's NetworkAttachmentDefinition before creating any kernel state (internal/nadpatch.VerifyChainComplete, wired into internal/cni/ops_add.go and internal/cnitap/ops_add.go), but the galactic-cni ClusterRole only ever granted "patch" on network-attachment-definitions — the verb needed for the later NAD annotation step, not this new pre-check. With the RBAC gap, every ADD failed with a Forbidden error before any interface, VRF, or route was created: chain completeness check: get NetworkAttachmentDefinition ns10/private: network-attachment-definitions.k8s.cni.cncf.io "private" is forbidden: User "system:serviceaccount:galactic-system:galactic-cni" cannot get resource "network-attachment-definitions" in API group "k8s.cni.cncf.io" in the namespace "ns10" Every pod attaching through the "private" NAD chain wedged in ContainerCreating. Found while running deploy/containerlab's task verify. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
privateip
force-pushed
the
fix/cni-rbac-nad-get
branch
from
August 17, 2026 20:35
2433bfa to
8111ffe
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
d3c1ca3(#331) added aGetcall on the pod'sNetworkAttachmentDefinitionbefore creating any kernel state(
internal/nadpatch.VerifyChainComplete), but thegalactic-cniClusterRole only granted
patchonnetwork-attachment-definitions—the verb the later NAD-annotation step needs, not this new pre-check.
Every ADD failed Forbidden before any interface, VRF, or route was
created, wedging every pod attaching through the "private" NAD chain in
ContainerCreating.Test plan
deploy/containerlabclusters;task verifypasses (bgp-transit, bgp-fabric, bgp-peers, srv6, evpn, gateway,
ns10–ns40 scenarios all green).
🤖 Generated with Claude Code