Repository navigation
Let owners remove a logo or background whose file is already gone - #219
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
PhilReinking
commented
Oct 10, 2026
PhilReinking
left a comment
PhilReinking
left a comment
Contributor
Author
There was a problem hiding this comment.
OK at f2b84fa, CI green.
Checked beyond the PR text: a path shared with another form (also a trashed one) keeps the file and the other form's path, also when the file is gone. A null or empty path and a second remove answer 200 and delete nothing. Resized copies of a missing file are cleared. Another team gets 403.
…issing-image # Conflicts: # CHANGELOG.md
PhilReinking
commented
Oct 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removing a logo or background did nothing when its file was already gone: the request returned 200 and the path stayed, so the form kept a broken image. Some forms have such paths from the shared-image bug fixed in #205.
Fixes BITS-180
Tested: full PHP suite. The new test for a missing file fails without the fix, for logo and background. The existing image tests cover removing a file that exists.
🤖 Generated with Claude Code