Open
Conversation
Signed-off-by: Polina Sizintseva <polina.sizintseva@flant.com>
odiora
force-pushed
the
chore/ci/move-go-lint-and-deps-to-taskfile
branch
from
b52b786 to
1df9b49
Compare
Signed-off-by: Polina Sizintseva <polina.sizintseva@flant.com>
Signed-off-by: Polina Sizintseva <polina.sizintseva@flant.com>
Fral738
reviewed
Apr 24, 2026
| deckhouse_lib_helm_ver: 1.71.2 | ||
| target: "" | ||
| VALIDATION_FILES: "tools/validation/{main,messages,diff,doc_changes}.go" | ||
| prettier_image: 'ghcr.io/deckhouse/virtualization/prettier:3.2.5' |
Collaborator
There was a problem hiding this comment.
replace image with public prettier
| cmds: | ||
| - test -x "{{.golangci_lint_bin}}" || (echo "golangci-lint not found at {{.golangci_lint_bin}}. Run 'task deps:install:golangci-lint' or 'task deps:install:all'."; exit 1) | ||
|
|
||
| format: |
Collaborator
There was a problem hiding this comment.
can we use our common-ci here for format?
| # TODO: update image reference | ||
| - task: format:yaml | ||
|
|
||
| _prettier:yaml: |
| - task: lint:doc-ru | ||
| - task: lint:prettier:yaml | ||
|
|
||
| lint:go: |
Collaborator
There was a problem hiding this comment.
Can we use lint from our common-ci?
| @@ -80,11 +265,9 @@ tasks: | |||
| lint:prettier:yaml: | |||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.