Add CreateDefaultStorageClass#9
Merged
mrwesadex-flant merged 6 commits intomainfrom Mar 25, 2026
Merged
Conversation
viktor-karpochev
force-pushed
the
vkarpochev-add-default-storage-class
branch
4 times, most recently
from
60d73e3 to
84bdaf3
Compare
viktor-karpochev
force-pushed
the
vkarpochev-add-default-storage-class
branch
from
84bdaf3 to
fdef01d
Compare
- Add CreateDefaultStorageClass in pkg/testkit/storageclass.go with IncludeMasters support and graceful skipping of tainted master nodes - Add BlockDevice and LocalStorageClass Kubernetes helpers - Add GetAllNodeNames, GetWorkerNodeNames, NodeHasUnschedulableTaint to nodes.go Signed-off-by: Viktor Karpochev <[email protected]> Made-with: Cursor
Signed-off-by: viktor-karpochev <[email protected]>
Signed-off-by: viktor-karpochev <[email protected]>
…tion - Add EnsureDefaultStorageClass: idempotent wrapper that checks for existing StorageClass before creating, then sets it as cluster default via global ModuleConfig (spec.settings.storageClass) - Add GetDefaultStorageClassName, StorageClassExists, SetGlobalDefaultStorageClass helpers in pkg/kubernetes/storageclass.go Signed-off-by: Viktor Karpochev <[email protected]> Made-with: Cursor
viktor-karpochev
force-pushed
the
vkarpochev-add-default-storage-class
branch
from
93b41d5 to
bd79f8a
Compare
- Updated WaitForLocalStorageClassCreated and WaitForStorageClass to use context with timeout and ticker for better control over waiting periods. - Renamed GetAllNodeNames to GetNodes and GetWorkerNodeNames to GetWorkerNodes, returning corev1.Node objects instead of just names. - Introduced GetNodeTaints and IsNodeCordoned functions for improved node taint management. - Updated CreateDefaultStorageClass to handle corev1.Node objects and check for cordoned nodes.
Previously returned an error on NotFound, causing EnsureDefaultStorageClass to fail instead of proceeding to create the StorageClass. Signed-off-by: Viktor Karpochev <[email protected]> Made-with: Cursor
mrwesadex-flant
approved these changes
Mar 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.