Skip to content

chore(e2e): fix long filenames#2248

Merged
nevermarine merged 4 commits intomainfrom
chore/e2e/fix-long-filenames
Apr 29, 2026
Merged

chore(e2e): fix long filenames#2248
nevermarine merged 4 commits intomainfrom
chore/e2e/fix-long-filenames

Conversation

@nevermarine
Copy link
Copy Markdown
Collaborator

@nevermarine nevermarine commented Apr 21, 2026

Description

Fix "file name too long" error in e2e test dump functions by truncating long test names in generated filenames.

Why do we need it, and what problem does it solve?

E2e tests with deeply nested Describe/It blocks produce very long spec names. When these names are used verbatim in dump filenames (e.g. e2e_failed__<testname>__<namespace>__events.yaml), the resulting path exceeds the 255-byte filename limit on Linux filesystems (ext4/xfs), causing the dump to fail with file name too long.

Example failing filename:

e2e_failed__virtualmachineadditionalnetworkinterfaces_verifies_interface_name_persistence_after_removing_middle_clusternetwork_should_preserve_interface_name_after_removing_middle_clusternetwork_and_rebooting__v12n-e2e-vm-additional-network-2wqtt__events.yaml

What is the expected result?

  1. Run an e2e test with a long nested spec name that previously failed to write dump files.
  2. Verify dump files are written successfully with a truncated name containing ... in the middle.

Checklist

  • The code is covered by unit tests.
  • e2e tests passed.
  • Documentation updated according to the changes.
  • Changes were tested in the Kubernetes cluster manually.

Signed-off-by: Maksim Fedotov <[email protected]>
@nevermarine nevermarine added this to the v1.8.0 milestone Apr 21, 2026
@nevermarine
Copy link
Copy Markdown
Collaborator Author

image

@nevermarine nevermarine marked this pull request as ready for review April 21, 2026 08:30
@nevermarine nevermarine requested a review from Isteb4k as a code owner April 21, 2026 08:30
Signed-off-by: Maksim Fedotov <[email protected]>
@nevermarine nevermarine modified the milestones: v1.8.0, v1.9.0 Apr 23, 2026
Comment thread test/e2e/internal/framework/dump.go Outdated
Signed-off-by: Maksim Fedotov <[email protected]>
Signed-off-by: Maksim Fedotov <[email protected]>
@nevermarine nevermarine merged commit 665ed27 into main Apr 29, 2026
27 of 28 checks passed
@nevermarine nevermarine deleted the chore/e2e/fix-long-filenames branch April 29, 2026 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants