[MPS] Update C++ Standard in CPUAdamBuilder - #8466
Merged
Merged
Conversation
…wer PyTorch versions Signed-off-by: iLeGend <824040212@qq.com>
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8008451b59
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
tohtana
approved these changes
Sep 10, 2026
tohtana
left a comment
tohtana
left a comment
Collaborator
There was a problem hiding this comment.
Thank you @jinyouzhi! This PR is very important to unblock the CI issue.
tohtana
enabled auto-merge
September 10, 2026 08:06
Contributor
Author
Thank you for your reviewing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Fix #8267 CI failure in MPS CPU, which block the pr ci.
Changes
This pull request updates the
cxx_argsmethod inop_builder/mps/cpu_adam.pyto improve compatibility with newer versions of PyTorch. The main change is to select the appropriate C++ standard based on the detected PyTorch version.Build compatibility improvement:
op_builder/mps/cpu_adam.py: The C++ standard used in compilation is now set to-std=c++20for PyTorch versions 2.12 and above, and remains-std=c++17for earlier versions. This ensures compatibility with recent PyTorch releases.