Skip to content

Allow public Swift ad SDK artifact hosts - #359

Open
uetyo wants to merge 1 commit into
dependabot:mainfrom
uetyo:allowlist-swift-ad-sdk-hosts
Open

uetyo wants to merge 1 commit into
dependabot:mainfrom
uetyo:allowlist-swift-ad-sdk-hosts

Conversation

@uetyo

@uetyo uetyo commented Nov 9, 2026 •

Copy link
Copy Markdown

What are you trying to accomplish?

Allow SwiftPM to download the binary targets of public AppLovin MAX and mediated ad SDKs through the egress proxy. Add four exact hosts under ecosystem_default_domains.swift:

Host Provider-owned manifest
artifacts.applovin.com AppLovinSDK
vungle2-cdn-prod.s3.amazonaws.com VungleAdsSDK
dl.inmobi.com InMobiSDK
cdn2.inner-active.mobi Digital Turbine Exchange / IASDKCore

Anything you want to highlight for special attention from reviewers?

All entries are exact hosts (no wildcards or leading dots) taken from the vendors' own public manifests. Vungle is a single S3 bucket; the shared s3.amazonaws.com apex stays blocked.

How will you know you've accomplished your goal?

  • Added positive probes for the archive URLs and negative probes (evil.<host>, parent domain, sibling bucket, path-style S3 apex) to TestEgressAllowlist_PublicVendorRegistriesAllowed. All archive URLs return 200 anonymously, without redirects.

Checklist

  • I have run the complete test suite to ensure all tests and linters pass.
  • I have thoroughly tested my code changes to ensure they work as expected, including adding additional tests for new functionality.
  • I have written clear and descriptive commit messages.
  • I have provided a detailed description of the changes in the pull request, including the problem it addresses, how it fixes the problem, and any relevant details about the implementation.
  • I have ensured that the code is well-documented and easy to understand.

@uetyo
uetyo requested a review from a team as a code owner November 9, 2026 02:30
@github-actions github-actions Bot added the allowlist Changes the default egress allowlist label Nov 9, 2026
@uetyo
uetyo marked this pull request as draft November 9, 2026 02:43
Add the hosts serving the binaryTargets declared in the public
Package.swift of AppLovin, Liftoff Monetize (VungleAds), InMobi and
Digital Turbine Exchange SDKs to the swift ecosystem allowlist. All are
exact hosts (no vendor wildcards, no path-style s3.amazonaws.com apex)
and serve anonymously without redirects.

🤷🤝🤖 Co-authored by uetyo and ClaudeCode
@uetyo
uetyo force-pushed the allowlist-swift-ad-sdk-hosts branch from 0651afc to 5adf8df Compare November 9, 2026 04:27
@uetyo
uetyo marked this pull request as ready for review November 9, 2026 04:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

allowlist Changes the default egress allowlist

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant