Repository navigation
ci: test optional pandas examples on Linux and Windows - #9
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The optional CSV adapter proposed in #8 skips eight pandas-dependent tests under the existing default CI installation. Add separate pandas-enabled jobs so that the complete suite and the adapter example are exercised once that contribution is present.
The new matrix covers pandas 2 / Python 3.11 on Linux, and pandas 3 / Python 3.12 on Linux and Windows. Existing default-install jobs continue to verify the dependency-free package. Pandas is not added to runtime dependencies. The example step is conditional because #8 has not merged into main; the full suite always runs.
Validation:
3aa3f9190d51a35cf52073e24359fa58313ef78d), isolated Python 3.12.14 environments passed all 88 tests with pandas 2.3.3 and 3.0.6, with no skips. Their CSV example output was byte-identical.git diff --checkpassed.Remote CI completed successfully on this PR head: all six Linux/Windows jobs passed at https://github.com/dev-belly/PITBridge/actions/runs/37865325374 . These checks cover the current main-based tree; the adapter remains separately proposed in #8. Local review also regenerated both evidence bundles on #8 with pandas 3.0.6: all 12 files matched the committed bundles byte for byte, and compileall passed.