Repository navigation
Conversation
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Activity selection is not Senegal-specific, and retry logic can omit missing indicator values.
Review effort: Balanced
Findings: 1
Open (2)
What changed in this PR
Seeds CDIP core indicator data for Senegal and registers its funding export job.
Changes:
- Adds indicator categories, indicators, connections, and demo values.
- Registers
AmpCoreIndicatorFundingJob.
| File | Description |
|---|---|
CDIP-AMP-core-indicator-funding-job.xml |
Seeds CDIP indicator data and registers the Quartz job. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| SELECT 1 | ||
| FROM amp_indicator_values existing | ||
| WHERE existing.ind_connect_id = connection.id | ||
| AND existing.value_type = value_type |
Comment on lines
+68
to
+70
| UPDATE amp_indicator_connection existing | ||
| SET activity_id = anchor.amp_activity_id, | ||
| activity_location = anchor.amp_activity_location_id |
| SELECT 1 | ||
| FROM amp_indicator_values existing | ||
| WHERE existing.ind_connect_id = connection.id | ||
| AND existing.value_type = value_type |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.