Repository navigation
Include security headers - #4517
Merged
jdeanquin-dg merged 2 commits intoOct 7, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Critical CSP trust and documentation issues remain unresolved.
Review effort: Lite
Findings: 2
Open (2)
What changed in this PR
Adds global security headers and expands the CSP for external resources.
Changes:
- Registers
SecurityHeadersFilterglobally. - Adds CSP directives for frames, workers, and external resources.
- Documents the updated security policy.
Two critical issues remain: script-src https: trusts all HTTPS origins, and CSP documentation is inconsistent with the configured directives.
| File | Summary |
|---|---|
amp/src/main/webapp/WEB-INF/web.xml |
Registers the security headers filter globally. |
amp/src/main/java/org/digijava/kernel/web/SecurityHeadersFilter.java |
Defines security headers and CSP policy; requires a specific script-origin allowlist and synchronized documentation. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.