Skip to content

Symbols generated by Devito should be generated using a symbol registry #2292

Open

Description

@EdCaunt

Symbols generated within Devito currently do not have guaranteed unique names, potentially producing inadvertent clashes which result in cryptic errors being raised.

Devito currently makes use of counters (among other means) to create unique names for internally-generated symbols. However, there is nothing preventing clashes either with other generated symbols or those defined by the user.

It would be beneficial to have a registry of symbols to generate unique names in a consistent manner, to be used throughout the codebase.

This functionality could potentially be introduced as a mixin class where needed.

Possible approach:

@cached_property
def name(self):
    if self._name is None:
         return compute_deterministic_hash(self._hashable_content()))
    else:
         return self._name 

or alternatively when setting name:

self._name = self._registry.get_unique_name(name)

where get_unique_name adds an increment to the supplied name as required.

Activity

  1. ggorman commented on Oct 22, 2026

    @ggorman
    Contributor

    Cross-references, since none of the related PRs cite this issue:

    Once #3084 merges, what remains of this issue is the DSL side: symbols created outside the compilation registry (derived dimensions and other user-facing objects) still pick their names through their own counters.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions