Merged
Conversation
mloubout
commented
Feb 19, 2026
| return super()._sympify(arg) | ||
| except sympy.SympifyError: | ||
| # Pure sympy object | ||
| return arg._sympy_() |
Contributor
Author
There was a problem hiding this comment.
Note: This prevents sympy from forcing some weird type conversion because of
That for example converts EnrichedTuples to sympy's tuples. By using _sympy_ explicitly it makes sure it only convert object with explicity conversion defined (so mostly pure sympy objects or our objects with it defined)
FabioLuporini
approved these changes
Feb 19, 2026
EdCaunt
approved these changes
Feb 19, 2026
3c94e46 to
a1334cb
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2854 +/- ##
=======================================
Coverage 78.96% 78.96%
=======================================
Files 248 248
Lines 50950 50980 +30
Branches 4405 4411 +6
=======================================
+ Hits 40232 40258 +26
- Misses 9917 9919 +2
- Partials 801 803 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
a1334cb to
9b10cfa
Compare
9b10cfa to
a60b12a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix issue using Staggering object as input for staggered