Skip to content

compiler: Fix buffering in presence of written HALO regions - #3030

Merged
mloubout merged 4 commits into
mainfrom
hotfix-buffering-cpml
Sep 18, 2026
Merged

mloubout merged 4 commits into
mainfrom
hotfix-buffering-cpml

Conversation

@FabioLuporini

Copy link
Copy Markdown
Contributor

No description provided.

@FabioLuporini FabioLuporini added the bug-C bug in the generated code label Sep 18, 2026
@codecov

codecov Bot commented Sep 18, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 89.28571% with 27 lines in your changes missing coverage. Please review.
✅ Project coverage is 83.90%. Comparing base (caf6fc9) to head (327c61f).

Files with missing lines Patch % Lines
tests/test_mpi.py 59.01% 25 Missing ⚠️
devito/passes/clusters/buffering.py 95.12% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3030      +/-   ##
==========================================
+ Coverage   83.87%   83.90%   +0.03%     
==========================================
  Files         258      258              
  Lines       55356    55605     +249     
  Branches     4730     4765      +35     
==========================================
+ Hits        46430    46658     +228     
- Misses       8111     8131      +20     
- Partials      815      816       +1     
Flag Coverage Δ
pytest-gpu-aomp-amdgpuX 68.65% <53.26%> (-0.02%) ⬇️
pytest-gpu-gcc- 78.56% <88.49%> (+0.04%) ⬆️
pytest-gpu-icx- 78.49% <88.49%> (+0.03%) ⬆️
pytest-gpu-nvc-nvidiaX 69.17% <53.26%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@FabioLuporini FabioLuporini added the no-pro-trigger Skip the devitopro submodule update on merge label Sep 18, 2026
Comment thread devito/ir/clusters/algorithms.py
if not halo_writes:
return clusters

# Expand the IterationSpace over the necessary amount of HALO; in doing so,

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not just call memcpy in that case since it just copies the whole buffer (the langbb['memcpy'])

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

padding

@mloubout
mloubout merged commit 760a476 into main Sep 18, 2026
42 checks passed
@mloubout
mloubout deleted the hotfix-buffering-cpml branch September 18, 2026 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug-C bug in the generated code no-pro-trigger Skip the devitopro submodule update on merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants