compiler: Fix buffering in presence of written HALO regions - #3030
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3030 +/- ##
==========================================
+ Coverage 83.87% 83.90% +0.03%
==========================================
Files 258 258
Lines 55356 55605 +249
Branches 4730 4765 +35
==========================================
+ Hits 46430 46658 +228
- Misses 8111 8131 +20
- Partials 815 816 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
FabioLuporini
force-pushed
the
hotfix-buffering-cpml
branch
from
September 18, 2026 13:07
a3047d5 to
dbb3e61
Compare
FabioLuporini
force-pushed
the
hotfix-buffering-cpml
branch
from
September 18, 2026 13:38
dbb3e61 to
4b366ca
Compare
mloubout
reviewed
Sep 18, 2026
mloubout
reviewed
Sep 18, 2026
| if not halo_writes: | ||
| return clusters | ||
|
|
||
| # Expand the IterationSpace over the necessary amount of HALO; in doing so, |
Contributor
There was a problem hiding this comment.
why not just call memcpy in that case since it just copies the whole buffer (the langbb['memcpy'])
FabioLuporini
force-pushed
the
hotfix-buffering-cpml
branch
from
September 18, 2026 14:24
4b366ca to
327c61f
Compare
mloubout
approved these changes
Sep 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.