Repository navigation
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3064 +/- ##
==========================================
- Coverage 84.23% 84.22% -0.01%
==========================================
Files 258 258
Lines 57070 57080 +10
Branches 4874 4873 -1
==========================================
+ Hits 48072 48076 +4
- Misses 8170 8174 +4
- Partials 828 830 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
| if isinstance(overrides, dict): | ||
| options.update(overrides) | ||
|
|
||
| # A listed `linearize` (e.g., `opt=('linearize', {})`) must run after the |
There was a problem hiding this comment.
linearize isn't supposed to be used as a mode it's an opt (mode, {'linearize': True})
There was a problem hiding this comment.
Fair enough. It was still registered as a pass (_known_passes and the custom IET mapper, with _specialize_iet special-casing it), but that path had been broken since 520ba95: silent no-op without the option, compile error with it. Reworked to drop it from the pass list, so opt=('linearize', ...) now errors out as an unknown pass; the option is untouched and always applied after DataManager.
`linearize` is an opt-option, not a pass. Listed as a pass it ran before the symbol definitions and either did nothing or produced uncompilable code, so it is no longer a known pass and the option is applied after DataManager as in the other pipelines.
7dba0ec to
3973620
Compare
FabioLuporini
left a comment
FabioLuporini
left a comment
There was a problem hiding this comment.
I don't see the point here
This branch has not been deployed
3 participants
opt=('linearize', ...)in a custom pass list ran before symbol definitions, emitting both macros and VLA casts, a compile error. It now becomes the homonymous option, asopenmpalready does.Test:
test_linearize.py::test_linearize_as_pass(three pass-list forms).Both this PR and #3065 append to the bottom of
test_linearize.py; whichever lands second needs a trivial rebase.🤖 Generated with Claude Code