Repository navigation
Conversation
On device backends a guard outside the kernels, or in a Cluster that runs on the host (e.g., a copy-back to a host Function), is evaluated on the host against the stale host copy of a Function updated on the device. E.g., `if (T[0][2][0] < 1.5F)` around a kernel launch while `T` is written by another kernel. Raise a CompilationError instead of silently computing wrong results
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3069 +/- ##
==========================================
+ Coverage 84.23% 84.24% +0.01%
==========================================
Files 258 258
Lines 57070 57102 +32
Branches 4874 4878 +4
==========================================
+ Hits 48072 48106 +34
+ Misses 8170 8169 -1
+ Partials 828 827 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
ggorman
marked this pull request as ready for review
October 19, 2026 18:41
FabioLuporini
left a comment
FabioLuporini
left a comment
Contributor
There was a problem hiding this comment.
I also think this is practically speaking useless
| def _lower_clusters(cls, expressions, **kwargs): | ||
| clusters = super()._lower_clusters(expressions, **kwargs) | ||
|
|
||
| # The host copy of a Function written on the device is stale, so a guard |
Contributor
There was a problem hiding this comment.
this is sloppy. This probably requires its own pass right after ir/clusters/algorithms.py's guard(...) pass
FabioLuporini
requested changes
Oct 20, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On device backends a guard evaluated on the host (outside kernels, or around a host Cluster) read the stale host copy of a Function updated on the device, e.g.
if (T[0][2][0] < 1.5F)around a launch. Such guards are now refused with aCompilationError.Test:
test_gpu_common.py::TestPassesEdgeCases::test_guard_reads_device_data[noop|advanced](a spatial guard is accepted and checked for values, a temporal one is refused).🤖 Generated with Claude Code