Conversation
…evonfw#1751-create-go-commandlet
Pull Request Test Coverage Report for Build 23428502852Details
💛 - Coveralls |
There was a problem hiding this comment.
Pull request overview
Adds a new Go tool commandlet to IDEasy CLI, including tagging/help text integration and a dedicated install test project to validate installation behavior.
Changes:
- Introduce
Gotool commandlet and register it in the CLI commandlet manager. - Add Go tag and NLS help entries (EN/DE).
- Add
GoTestplus test resources for a mock Go tool repository and URL metadata.
Reviewed changes
Copilot reviewed 9 out of 11 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
cli/src/main/java/com/devonfw/tools/ide/tool/go/Go.java |
New Go tool commandlet implementation. |
cli/src/main/java/com/devonfw/tools/ide/common/Tag.java |
Adds Tag.GO for tool classification. |
cli/src/main/java/com/devonfw/tools/ide/commandlet/CommandletManagerImpl.java |
Registers the Go commandlet. |
cli/src/main/resources/nls/Help.properties |
Adds English help/description keys for go. |
cli/src/main/resources/nls/Help_de.properties |
Adds German help/description keys for go. |
cli/src/test/java/com/devonfw/tools/ide/tool/go/GoTest.java |
New parameterized install test for Go across OS mocks. |
cli/src/test/resources/ide-projects/go/repository/go/go/default/src/make.bash |
Mock repository payload for Go installation tests. |
cli/src/test/resources/ide-projects/go/_ide/urls/go/go/1.22.4/urls |
URL metadata for the Go test project. |
cli/src/test/resources/ide-projects/go/project/workspaces/main/.gitkeep |
Ensures workspace folder exists in test project. |
cli/src/test/resources/ide-projects/go/project/settings/ide.properties |
Test project settings placeholder. |
CHANGELOG.adoc |
Adds changelog entry for issue #1751. |
You can also share your feedback on Copilot code review. Take the survey.
cli/src/test/resources/ide-projects/go/_ide/urls/go/go/1.22.4/urls
Outdated
Show resolved
Hide resolved
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
hohwille
left a comment
There was a problem hiding this comment.
@MarvMa thanks for integrationg Go into IDEasy so quickly. Great job 👍
The commandlet is pretty simple and straight forward what shows the beauty of our OOP design we meanwhile have with Java (compared to devonfw-ide where we implemented commandlets as bash scripts).
Great that you also added a test and test project as well as CHANGELOG.
I left some small comments for improvement.
When resolved we can merge.
cli/src/test/resources/ide-projects/go/repository/go/go/default/src/make.bash
Show resolved
Hide resolved
|
The requested changes have been implemented. Are the included tests sufficient enough? @hohwille |
Thanks for the improvement! 👍 |
This PR fixes #1751
Implemented changes:
Checklist for this PR
Make sure everything is checked before merging this PR. For further info please also see
our DoD.
mvn clean testlocally all tests pass and build is successful#«issue-id»: «brief summary»(e.g.#921: fixed setup.bat). If no issue ID exists, title only.In Progressand assigned to you or there is no issue (might happen for very small PRs)with
internalChecklist for tool commandlets
Have you added a new
«tool»as commandlet? There are the following additional checks:«tool»«TOOL»_VERSIONand«TOOL»_EDITIONare honored by your commandlet