fix: Fall back to v3 certificate parsing if certificate is not v4#723
Merged
fix: Fall back to v3 certificate parsing if certificate is not v4#723
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates delegated certificate authorization to support older (non-sharded) canister range encodings by falling back to /subnet/<subnet_id>/canister_ranges when the sharded /canister_ranges/<subnet_id>/... subtree is not available.
Changes:
- Attempt to read canister ranges from the sharded
/canister_ranges/<subnet_id>/<shard>layout (v4-style). - Fall back to reading canister ranges from
/subnet/<subnet_id>/canister_ranges(v3-style) when the sharded subtree is absent/unknown. - Preserve existing effective-canister authorization check against the parsed ranges.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
lwshang
approved these changes
Apr 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.