test(DSM): Update tests to pass with or without deterministic tracker…#9894
Merged
adambratschikaye merged 5 commits intomasterfrom Apr 16, 2026
Merged
test(DSM): Update tests to pass with or without deterministic tracker…#9894adambratschikaye merged 5 commits intomasterfrom
adambratschikaye merged 5 commits intomasterfrom
Conversation
… charging Modify instrumentation, benchmark, and subnet-size tests so they produce correct expected values regardless of whether the deterministic memory tracker charges instructions for dirty and accessed pages. - Instrumentation tests: account for the per-OS-page instruction overhead charged in-band by the SIGSEGV handler when the tracker is enabled. - Benchmark reference counts: add helpers deterministic_tracker_overhead() and deterministic_tracker_write_overhead() that return zero when the tracker is disabled and the appropriate per-Wasm-page cost when it is enabled. Use the actual OS page size (ic_sys::PAGE_SIZE) rather than a hard-coded 4096 so the values are correct on arm64-darwin (16 KiB pages) as well as on Linux (4 KiB pages). - Subnet-size test: apply the same page-size-aware overhead helper to the reference instruction count used in test_subnet_size_execute_message_cost.
michael-weigelt
approved these changes
Apr 15, 2026
adambratschikaye
force-pushed
the
abk/fix-dsm-tests
branch
from
9262c7e to
6a00c61
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… charging
Modify instrumentation, benchmark, and subnet-size tests so they produce correct expected values regardless of whether the deterministic memory tracker charges instructions for dirty and accessed pages.