feat: add propose-to-delete-subnet command to ic-admin#9897
Conversation
Add the CLI subcommand to submit a DeleteSubnet proposal to the governance canister via ic-admin. The NnsFunction::DeleteSubnet and the registry canister's delete_subnet endpoint already exist; this wires up the missing ic-admin side so operators can submit the proposal.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
This pull request changes code owned by the Governance team. Therefore, make sure that
you have considered the following (for Governance-owned code):
-
Update
unreleased_changelog.md(if there are behavior changes, even if they are
non-breaking). -
Are there BREAKING changes?
-
Is a data migration needed?
-
Security review?
How to Satisfy This Automatic Review
-
Go to the bottom of the pull request page.
-
Look for where it says this bot is requesting changes.
-
Click the three dots to the right.
-
Select "Dismiss review".
-
In the text entry box, respond to each of the numbered items in the previous
section, declare one of the following:
-
Done.
-
$REASON_WHY_NO_NEED. E.g. for
unreleased_changelog.md, "No
canister behavior changes.", or for item 2, "Existing APIs
behave as before.".
Brief Guide to "Externally Visible" Changes
"Externally visible behavior change" is very often due to some NEW canister API.
Changes to EXISTING APIs are more likely to be "breaking".
If these changes are breaking, make sure that clients know how to migrate, how to
maintain their continuity of operations.
If your changes are behind a feature flag, then, do NOT add entrie(s) to
unreleased_changelog.md in this PR! But rather, add entrie(s) later, in the PR
that enables these changes in production.
Reference(s)
For a more comprehensive checklist, see here.
GOVERNANCE_CHECKLIST_REMINDER_DEDUP
r-birkner
dismissed
github-actions[bot]’s stale review
This just adds the functionality for ic-admin to submit a proposal to delete a subnet (cloud engine). No changes in any of the canisters.
2 participants
propose-to-delete-subnetsubcommand toic-adminso operators can submitDeleteSubnetproposals to the governance canisterNnsFunction::DeleteSubnet(ID 57) and the registry canister'sdelete_subnetendpoint already exist. This wires up the missing CLI side--subnet-idflag and follows the same pattern as other proposal commands (e.g.,propose-to-take-subnet-offline-for-repairs)