perf: optimize body parsing and buffering in request handling with onDataV2#335
Closed
nigrosimone wants to merge 3 commits intodimdenGD:mainfrom
Closed
perf: optimize body parsing and buffering in request handling with onDataV2#335nigrosimone wants to merge 3 commits intodimdenGD:mainfrom
nigrosimone wants to merge 3 commits intodimdenGD:mainfrom
Conversation
|
You can only use maxRemainingBodyLength if it is less than your upper buffer size. maxRemainingBodyLength will be essentially infinity for chunked requests. |
Co-authored-by: Copilot <[email protected]>
Contributor
Author
|
Good catch @uNetworkingAB . I was using maxRemainingBodyLength for preallocation too broadly, but that is not valid for chunked requests. I changed it so it is only used when it is safely bounded by the parser limit; otherwise the code falls back to dynamic buffering. You can make a new code review? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Switches from
onDatatoonDataV2which exposesmaxRemainingBodyLengththe exact number of bytes remaining in the request body. This enables several performance optimizations like pre-allocated body buffer.PR BENCHMARK
MASTER BENCHMARK