Conversation
rprospero
force-pushed
the
node_ancestor_search
branch
from
b02e924 to
204381c
Compare
trisyoungs
approved these changes
Mar 12, 2026
src/nodes/node.cpp
Outdated
| } | ||
| } | ||
|
|
||
| std::set<const Node *> Node::ancestors_() const |
Member
There was a problem hiding this comment.
Suggested change
| std::set<const Node *> Node::ancestors_() const | |
| // Get all nodes that lead into this node | |
| std::set<const Node *> Node::ancestors_() const |
src/nodes/node.h
Outdated
| return NodeConstants::ProcessResult::Failed; | ||
| } | ||
| // Get all nodes that lead into this node | ||
| std::set<const Node *> ancestors_() const; |
Member
There was a problem hiding this comment.
This would be the sole example of a function with this name_ convention in the codebase I think - not a problem per se, but is there an alternative name we could give it to clarify its intent? Perhaps rename the public function to getAncestors() (which makes it consistent with e.g. getNode()) and rename this to ancestors()?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the ability for a node to recursively examine its inputs. A template parameter filters for only nodes of the given type.