Merged
Conversation
trisyoungs
changed the title
rprospero
approved these changes
Mar 13, 2026
trisyoungs
force-pushed
the
dissolve2/no-forces-module-node
branch
from
b35bb06 to
be6bb92
Compare
…table as a static function (needs Node::dissolveGraph() in order to create kernels).
trisyoungs
force-pushed
the
dissolve2/md-node-unit-test
branch
from
66840d9 to
2339716
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Build on #2336 - Do not merge until #2336 is resolved.
This PR turns the
MDNodeinto a single file, removing the species-specific MD function since it is not implementable under the new framework (reimplementing it to make more use of theConfiguration-centred MD code is a job for future me). The old MD module unit test is removed and not reimplemented - it didn't really test anything useful and was more of a test of the restart file than the MD capabilities.