-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Rebase meeting minutes pr2221 #2384
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
The new link points to the new minutes repo. Also updated the tests related to it.
The tests need to be rewritten to not use Meetings.
have also added migrations
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
The tests need ReleaseMixin to create DocumentRelease test data, which is required when rendering templates with the search form.
…djangoproject.com into rebase-meeting-minutes-pr2221
for more information, see https://pre-commit.ci
|
@knyghty can you take a look at this rebase and if all looks good to you. This is the rebased #2221 that you and @CaptainJack2491 had been working on. |
knyghty
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks correct to me. Thanks for the extra work here.
|
I just want to question whether we want to drop the tables around terms and board members. |
|
@sarahboyce I think you're right to question that but I can't say I have a very compelling answer or opinion either way. I think it is nice to have this if we show it somewhere. And in order to show it somewhere maybe nice to not delete it and the data with it. I question a bit whether we'd keep a database table up to date that isn't actually displayed anywhere, but I suppose if we did agree to implement something like this in the near future I can definitely see the benefit. At the moment though will still have the board listing as a flatpage and I'd be tempted to say that's enough. But I also see your point about being able to re-use this information elsewhere. So as usual I just wrote a longwinded way of saying "dunno", which is not extremely helpful for anyone, so maybe we should wait and hope for other opinions. |
|
Personally I would remove the deletion of the board and terms from this PR and have this in a follow up PR to be discussed/approved separately. The information only needs updating once a year, not updating it for 3 years is not too difficult to backfill. There might be no plans to use this for making the board list dynamic, displaying past boards, using for permissions, profiles etc. But I currently see potential, so I think the @django/django-website wg should discuss it before we drop the tables. |
|
Makes sense to me. |
This PR rebases and continues the work from #2221 by @CaptainJack2491.
Changes
Context
The original PR (#2221) needed rebasing due to conflicts with recent changes. This PR applies those changes on top of the current main branch.
Closes #2221