Skip to content

Conversation

@jcjudkins
Copy link
Member

This PR rebases and continues the work from #2221 by @CaptainJack2491.

Changes

  • Updates Django meeting minutes links to point to the new minutes repository
  • Removes old meeting minute references and template tags
  • Adds redirects for old minute URLs
  • Updates tests to reflect the new structure

Context

The original PR (#2221) needed rebasing due to conflicts with recent changes. This PR applies those changes on top of the current main branch.

Closes #2221

CaptainJack2491 and others added 11 commits December 8, 2025 14:38
The new link points to the new minutes repo. Also updated the tests
related to it.
The tests need to be rewritten to not use Meetings.
The tests need ReleaseMixin to create DocumentRelease test data,
which is required when rendering templates with the search form.
…djangoproject.com into rebase-meeting-minutes-pr2221
@jcjudkins jcjudkins requested a review from SaptakS December 8, 2025 21:18
@jcjudkins jcjudkins self-assigned this Dec 8, 2025
@jcjudkins jcjudkins requested a review from sarahboyce December 8, 2025 21:23
@SaptakS
Copy link
Contributor

SaptakS commented Dec 11, 2025

@knyghty can you take a look at this rebase and if all looks good to you. This is the rebased #2221 that you and @CaptainJack2491 had been working on.

Copy link
Member

@knyghty knyghty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks correct to me. Thanks for the extra work here.

@sarahboyce
Copy link
Contributor

I just want to question whether we want to drop the tables around terms and board members.
We have some existing functionality where user accounts have a profile page. Adding the past/existing board members terms/responsibilities onto these pages seems quite a reasonable request and relatively easy thing to acheive currently. Are we sure we don't want to keep these existing tables/data before we drop it all?

@knyghty
Copy link
Member

knyghty commented Dec 18, 2025

@sarahboyce I think you're right to question that but I can't say I have a very compelling answer or opinion either way. I think it is nice to have this if we show it somewhere. And in order to show it somewhere maybe nice to not delete it and the data with it. I question a bit whether we'd keep a database table up to date that isn't actually displayed anywhere, but I suppose if we did agree to implement something like this in the near future I can definitely see the benefit.

At the moment though will still have the board listing as a flatpage and I'd be tempted to say that's enough. But I also see your point about being able to re-use this information elsewhere.

So as usual I just wrote a longwinded way of saying "dunno", which is not extremely helpful for anyone, so maybe we should wait and hope for other opinions.

@sarahboyce
Copy link
Contributor

Personally I would remove the deletion of the board and terms from this PR and have this in a follow up PR to be discussed/approved separately.

The information only needs updating once a year, not updating it for 3 years is not too difficult to backfill. There might be no plans to use this for making the board list dynamic, displaying past boards, using for permissions, profiles etc. But I currently see potential, so I think the @django/django-website wg should discuss it before we drop the tables.

@knyghty
Copy link
Member

knyghty commented Dec 19, 2025

Makes sense to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants