Skip to content

Enhance font-weight for bold elements in SCSS#6897

Merged
donker merged 1 commit intodnnsoftware:developfrom
uzmannazari:patch-5
Mar 6, 2026
Merged

Enhance font-weight for bold elements in SCSS#6897
donker merged 1 commit intodnnsoftware:developfrom
uzmannazari:patch-5

Conversation

@uzmannazari
Copy link
Contributor

@uzmannazari uzmannazari commented Jan 8, 2026

Fixes #6755

Summary

This PR fixes an issue where <strong> and <b> elements were not rendered as bold in the Aperture theme.

A global reset rule was inheriting the full font property for these elements, which unintentionally removed the browser default bold behavior and caused them to render with the same font weight as their parent.

An explicit override using:

b, strong { font-weight: bolder; }

restores the expected semantic behavior by matching standard user-agent styling, without hard-coding a specific font weight or impacting layout and typography elsewhere.

Copy link
Contributor

@valadas valadas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like an OK solution, however @david-poindexter would you be open to instead refactor the _reset.css which I believe may be a bit old reference with things maybe too strong and lacking more modern elements.

Something like https://www.npmjs.com/package/modern-normalize

@mitchelsellers
Copy link
Contributor

@dnnsoftware/approvers What do we think about just getting this one approved?

@valadas
Copy link
Contributor

valadas commented Feb 26, 2026

I think we should instead replace https://github.com/dnnsoftware/Dnn.Platform/blob/develop/DNN%20Platform/Dnn.ClientSide/src/styles/default-css/10.0.0/base/_reset.scss with https://www.npmjs.com/package/modern-normalize

This issue may affect parts where the theme is not used as it is very global, so it looks like a better fix to me and reduces code instead of adding.

@donker
Copy link
Contributor

donker commented Feb 26, 2026

I think we should instead replace https://github.com/dnnsoftware/Dnn.Platform/blob/develop/DNN%20Platform/Dnn.ClientSide/src/styles/default-css/10.0.0/base/_reset.scss with https://www.npmjs.com/package/modern-normalize

This issue may affect parts where the theme is not used as it is very global, so it looks like a better fix to me and reduces code instead of adding.

But that would change the scope of this issue. How about incorporating this and then fixing the reset in another PR and you can roll this change back at that point?

@mitchelsellers
Copy link
Contributor

I would agree with @donker I think at this point, as the change to reset at the 10.0.0 level would have more of an impact than just the Aperture theme

@bdukes bdukes added this to the 10.2.4 milestone Mar 3, 2026
@donker donker merged commit 8d0e74f into dnnsoftware:develop Mar 6, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Enhancement]: Aperture > Add separator to header when content scrolled

5 participants