Open
Conversation
bdukes
force-pushed
the
obsolete
branch
3 times, most recently
from
8d52554 to
0f943b6
Compare
bdukes
force-pushed
the
obsolete
branch
3 times, most recently
from
a7adc9c to
92a0d05
Compare
bdukes
force-pushed
the
obsolete
branch
2 times, most recently
from
e70686c to
953c786
Compare
Pass in dependencies to FileManager via constructor
valadas
requested changes
Feb 24, 2026
Contributor
valadas
left a comment
valadas
left a comment
There was a problem hiding this comment.
Left a few comments/questions but the major issue is that casing was changed on some API controllers returns that are causing issues in the frontend, most notably the Site Settings persona bar module is not working.
| public IHttpActionResult Logout() | ||
| { | ||
| return JwtController.Instance.LogoutUser(this.Request) ? (IHttpActionResult)this.Ok(new { success = true }) : this.Unauthorized(); | ||
| return JwtController.Instance.LogoutUser(this.Request) ? (IHttpActionResult)this.Ok(new { Success = true, }) : this.Unauthorized(); |
Contributor
There was a problem hiding this comment.
This casing change in the dynamic object might be breaking for consumers of this response.
| res = new CachedCountryList(locale); | ||
| DotNetNuke.Common.Utilities.DataCache.SetCache(CacheKey(locale), res); | ||
| res = new CachedCountryList(listController); | ||
| DataCache.SetCache(CacheKey("none"), res); |
Contributor
There was a problem hiding this comment.
Was the change to "none" here intentional?
| @@ -338,34 +381,34 @@ public HttpResponseMessage GetDefaultPagesSettings(int? portalId, string culture | |||
| { | |||
| Settings = new | |||
| { | |||
| PortalId = portal.PortalID, | |||
| ((IPortalInfo)portal).PortalId, | |||
Contributor
There was a problem hiding this comment.
This could change the casing of the json right, which may make the frontend choke on that change
| @@ -453,15 +496,15 @@ public HttpResponseMessage GetMessagingSettings(int? portalId) | |||
| { | |||
| Settings = new | |||
| { | |||
| PortalId = portal.PortalID, | |||
| ((IPortalInfo)portal).PortalId, | |||
Contributor
There was a problem hiding this comment.
Same here on the casing change affecting the response json
Comment on lines
+1154
to
+1155
| a.PortalAliasId, | ||
| a.HttpAlias, |
Contributor
There was a problem hiding this comment.
Same here about casing for the json
| @@ -1572,15 +1610,15 @@ public HttpResponseMessage GetPrivacySettings(int? portalId) | |||
| { | |||
| Settings = new | |||
| { | |||
| PortalId = portal.PortalID, | |||
| ((IPortalInfo)portal).PortalId, | |||
| var availablePortals = portals.Select(v => new | ||
| { | ||
| v.PortalID, | ||
| v.PortalId, |
| @@ -2261,7 +2299,7 @@ public HttpResponseMessage GetLanguageSettings(int? portalId) | |||
|
|
|||
| var settings = new | |||
| { | |||
| PortalId = portal.PortalID, | |||
| ((IPortalInfo)portal).PortalId, | |||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR resolves obsolete warnings in DotNetNuke.Library from 1,205 to 1,016.