Add time and block hash to StateHeader#203
Open
ed255 wants to merge 19 commits into
Open
Conversation
This option fails because a predicate in TxLib ends up having 9 wildcards, and we have a maximum of 8
dhvanipa
reviewed
Jul 23, 2026
| } | ||
|
|
||
| /// Lossy conversion of a 256 bit value to a pod2 Hash | ||
| pub fn b256_to_hash(v: B256) -> Hash { |
Collaborator
There was a problem hiding this comment.
hmm are there any implications of doing a lossy conversion? Would we ever need to recover the original 256-bit hash or verify a StateHeader.block_hash against a real Ethereum block hash?
dhvanipa
reviewed
Jul 23, 2026
| impl StateHeader { | ||
| pub fn new( | ||
| block_number: i64, | ||
| block_time: i64, |
Collaborator
There was a problem hiding this comment.
nit: some places use block_time and others block_timestamp
eg podlang field uses block_time also
I would propose we use the same name everywhere, I'm okay with either
dhvanipa
approved these changes
Jul 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolve #200
Tested end to end with
just devand thenFindLogfrom the gui.