tests: replace aaa/bbb node names with descriptive builder names#3470
Open
yzewei wants to merge 1 commit intodocker:masterfrom
Open
tests: replace aaa/bbb node names with descriptive builder names#3470yzewei wants to merge 1 commit intodocker:masterfrom
yzewei wants to merge 1 commit intodocker:masterfrom
Conversation
Member
|
PTAL the ci |
Author
|
fix this format problem |
Member
|
@yzewei sorry, needs rebase. |
Signed-off-by: yzewei <yangzewei@loongson.cn>
Member
|
Rebased myself |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current buildx driver tests use generic placeholder node names like "aaa", "bbb", and "ccc".
This makes the tests less readable and harder to understand for new contributors.
This patch updates all node names in driver_test.go to semantic, descriptive names
reflecting their platform, e.g., "builder-amd64", "builder-riscv64", "builder-armv8", etc.
No test logic is changed; the patch only improves readability and maintainability
of the tests.