Add e2e test for authorized pull/push to private repo#6194
Open
AryanSharma9917 wants to merge 2 commits intodocker:masterfrom
Open
Add e2e test for authorized pull/push to private repo#6194AryanSharma9917 wants to merge 2 commits intodocker:masterfrom
AryanSharma9917 wants to merge 2 commits intodocker:masterfrom
Conversation
Signed-off-by: Aryan Sharma <[email protected]>
vvoland
requested changes
Jul 18, 2025
Collaborator
vvoland
left a comment
There was a problem hiding this comment.
Thanks!
This should setup a temporary registry with auth that the CLI connects to, so we don't rely on the Docker Hub and don't need to put real credentials for tests.
Author
Thanks! I’ll update the test to spin up a temporary |
Signed-off-by: Aryan Sharma <[email protected]>
Author
|
@vvoland could you please give my PR review? |
Collaborator
|
Hi, looks like the CI is red |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- What I did
Added an end-to-end (e2e) test to verify authenticated pull and push operations to a private Docker registry.
- How I did it
Created
e2e/auth_test.gowhich:DOCKER_USERNAME,DOCKER_PASSWORD,PRIVATE_REPO)- How to verify it
Run the e2e test with the required environment variables set in your local or CI environment.
- Human readable description for the release notes
- Related issue
Closes #5965